Re: [RFC PATCH] PCI-E broken on PPC (regression)
From: Jesse Barnes <hidden>
Date: 2010-01-25 20:45:36
From: Jesse Barnes <hidden>
Date: 2010-01-25 20:45:36
On Mon, 25 Jan 2010 11:42:29 -0200 Breno Leitao [off-list ref] wrote:
Hello, I found that qlge is broken on PPC, and it got broken after commit 06a1cbafb253c4c60d6a54a994887f5fbceabcc0. It happens because dev->pcie is not set on PPC, because the function set_pcie_port_type(), who sets dev->pcie, is not being called on PPC PCI code.
You mean dev->is_pcie? Why isn't pci_scan_device calling pci_setup_device for you? That should do the proper PCIe init depending on the device, along with extracting other device info... -- Jesse Barnes, Intel Open Source Technology Center