Re: [PATCH/RFC 2/2] 5200: improve i2c bus error recovery

Am 25.01.10 08:55 schrieb(en) Wolfgang Grandegger:

Albrecht Dreß wrote:

quoted

Make the I2C adapter timeout configurable through a Device Tree property which gives the timeout in microseconds.

My understanding is that software properties should not be defined via the device tree. I think a sysfs entry is more appropriate.

Is the timeout really a /software/ property?  My feeling is that the timeout basically depends upon the bus clock and the chips attached to the bus.  Therefore, it is linked closer to the composition of the board's hardware as described in the device tree, than to any userland software.  Or am I totally wrong here?

Thanks, Albrecht.

Albrecht Dreß wrote:

Am 25.01.10 08:55 schrieb(en) Wolfgang Grandegger:

quoted

Albrecht Dreß wrote:

quoted

Make the I2C adapter timeout configurable through a Device Tree
property which gives the timeout in microseconds.

My understanding is that software properties should not be defined via
the device tree. I think a sysfs entry is more appropriate.

Is the timeout really a /software/ property?  My feeling is that the
timeout basically depends upon the bus clock and the chips attached to
the bus.  Therefore, it is linked closer to the composition of the
board's hardware as described in the device tree, than to any userland
software.  Or am I totally wrong here?

Well, yes, it seems to be a border case.

Wolfgang.