# Re: \[PATCH 2/3\] of: make set\_node\_proc\_entry private to proc\_devtree.c

- From: Grant Likely \<hidden\>
- Date: 2009-12-23 14:48:45 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2009/12/1340783
- Thread: https://ratatoskr.run/linuxppc-dev/2009/12/1340623/t.md

```text
On Tue, Dec 22, 2009 at 6:45 PM, Jeremy Kerr [ref] wrote:
> We only need set_node_proc_entry in proc_devtree.c, so move it there.
>
> This fixes the !HAVE_ARCH_DEVTREE_FIXUPS build, as we can't make make
> the definition in linux/of.h conditional on this #define (definitions in
> asm/prom.h can't be exposed to linux/of.h, due to the enforced #include
> ordering).
>
> Signed-off-by: Jeremy Kerr <redacted>

A little ugly, but it can probably be refactored and cleaned up later
(like a lot of other things in the merged code).  Otherwise these
three patches look good to me.  I've picked them up into my tree and
I'll push them out soon.

g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
```
