[PATCH 1/3] powerpc/82xx: Fix BCSR bits for MPC8272ADS boards

Subsystems: linux for powerpc (32-bit and 64-bit), the rest

STALE6209d

2 messages, 2 authors, 2009-08-25 · open the first message on its own page

[PATCH 1/3] powerpc/82xx: Fix BCSR bits for MPC8272ADS boards

From: Anton Vorontsov <hidden>
Date: 2009-08-18 23:28:12

mpc8272_ads.c is using BCSR bits definitions from pq2ads.h, but
according to User's Guide the bits are wrong for MPC8272ADS boards
(I guess definitions from pq2ads should only be used for PQ2FADS
boards).

So, let's introduce our own definitions for MPC8272ADS, and don't
include pq2ads.h.

Signed-off-by: Anton Vorontsov <redacted>
---
 arch/powerpc/platforms/82xx/mpc8272_ads.c |    8 +++++++-
 1 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/arch/powerpc/platforms/82xx/mpc8272_ads.c b/arch/powerpc/platforms/82xx/mpc8272_ads.c
index 8054c68..67e2184 100644
--- a/arch/powerpc/platforms/82xx/mpc8272_ads.c
+++ b/arch/powerpc/platforms/82xx/mpc8272_ads.c
@@ -29,7 +29,6 @@
 #include <sysdev/fsl_soc.h>
 #include <sysdev/cpm2_pic.h>
 
-#include "pq2ads.h"
 #include "pq2.h"
 
 static void __init mpc8272_ads_pic_init(void)
@@ -144,6 +143,13 @@ static void __init mpc8272_ads_setup_arch(void)
 		return;
 	}
 
+#define BCSR1_FETHIEN		0x08000000
+#define BCSR1_FETH_RST		0x04000000
+#define BCSR1_RS232_EN1		0x02000000
+#define BCSR1_RS232_EN2		0x01000000
+#define BCSR3_FETHIEN2		0x10000000
+#define BCSR3_FETH2_RST		0x08000000
+
 	clrbits32(&bcsr[1], BCSR1_RS232_EN1 | BCSR1_RS232_EN2 | BCSR1_FETHIEN);
 	setbits32(&bcsr[1], BCSR1_FETH_RST);
 
-- 
1.6.3.3

Re: [PATCH 1/3] powerpc/82xx: Fix BCSR bits for MPC8272ADS boards

From: Kumar Gala <hidden>
Date: 2009-08-25 14:44:48

On Aug 18, 2009, at 6:28 PM, Anton Vorontsov wrote:
mpc8272_ads.c is using BCSR bits definitions from pq2ads.h, but
according to User's Guide the bits are wrong for MPC8272ADS boards
(I guess definitions from pq2ads should only be used for PQ2FADS
boards).

So, let's introduce our own definitions for MPC8272ADS, and don't
include pq2ads.h.

Signed-off-by: Anton Vorontsov <redacted>
---
arch/powerpc/platforms/82xx/mpc8272_ads.c |    8 +++++++-
1 files changed, 7 insertions(+), 1 deletions(-)

applied to next.

- k
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help