[PATCH] powerpc/mm: Fix switch_mmu_context to iterate of the proper list of cpus

Subsystems: linux for powerpc (32-bit and 64-bit), the rest

STALE6242d

4 messages, 3 authors, 2009-08-05 · open the first message on its own page

[PATCH] powerpc/mm: Fix switch_mmu_context to iterate of the proper list of cpus

From: Kumar Gala <hidden>
Date: 2009-08-05 03:33:38

Introduced a temporary variable into our iterating over the list cpus
that are threads on the same core.  For some reason Ben forgot how for
loops work.

Signed-off-by: Kumar Gala <redacted>
---
 arch/powerpc/mm/mmu_context_nohash.c |    9 +++++----
 1 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/arch/powerpc/mm/mmu_context_nohash.c b/arch/powerpc/mm/mmu_context_nohash.c
index 6e8d2d9..9859dcd 100644
--- a/arch/powerpc/mm/mmu_context_nohash.c
+++ b/arch/powerpc/mm/mmu_context_nohash.c
@@ -190,7 +190,7 @@ static void context_check_map(void) { }
 
 void switch_mmu_context(struct mm_struct *prev, struct mm_struct *next)
 {
-	unsigned int id, cpu = smp_processor_id();
+	unsigned int i, id, cpu = smp_processor_id();
 	unsigned long *map;
 
 	/* No lockless fast path .. yet */
@@ -268,9 +268,10 @@ void switch_mmu_context(struct mm_struct *prev, struct mm_struct *next)
 		local_flush_tlb_mm(next);
 
 		/* XXX This clear should ultimately be part of local_flush_tlb_mm */
-		for (cpu = cpu_first_thread_in_core(cpu);
-		     cpu <= cpu_last_thread_in_core(cpu); cpu++)
-			__clear_bit(id, stale_map[cpu]);
+		for (i = cpu_first_thread_in_core(cpu);
+		     i <= cpu_last_thread_in_core(cpu); i++) {
+			__clear_bit(id, stale_map[i]);
+		}
 	}
 
 	/* Flick the MMU and release lock */
-- 
1.6.0.6

Re: [PATCH] powerpc/mm: Fix switch_mmu_context to iterate of the proper list of cpus

From: Josh Boyer <hidden>
Date: 2009-08-05 11:32:42

On Tue, Aug 04, 2009 at 10:33:32PM -0500, Kumar Gala wrote:
Introduced a temporary variable into our iterating over the list cpus
that are threads on the same core.  For some reason Ben forgot how for
loops work.
Have the powerpoint demons corrupted him already??

josh

Re: [PATCH] powerpc/mm: Fix switch_mmu_context to iterate of the proper list of cpus

From: Michael Ellerman <hidden>
Date: 2009-08-05 12:52:23

On Wed, 2009-08-05 at 07:32 -0400, Josh Boyer wrote:
On Tue, Aug 04, 2009 at 10:33:32PM -0500, Kumar Gala wrote:
quoted
Introduced a temporary variable into our iterating over the list cpus
that are threads on the same core.  For some reason Ben forgot how for
loops work.
Have the powerpoint demons corrupted him already??
No I think one of his kids gave him swine flu.

cheers

Re: [PATCH] powerpc/mm: Fix switch_mmu_context to iterate of the proper list of cpus

From: Josh Boyer <hidden>
Date: 2009-08-05 13:16:18

On Wed, Aug 05, 2009 at 10:52:22PM +1000, Michael Ellerman wrote:
On Wed, 2009-08-05 at 07:32 -0400, Josh Boyer wrote:
quoted
On Tue, Aug 04, 2009 at 10:33:32PM -0500, Kumar Gala wrote:
quoted
Introduced a temporary variable into our iterating over the list cpus
that are threads on the same core.  For some reason Ben forgot how for
loops work.
Have the powerpoint demons corrupted him already??
No I think one of his kids gave him swine flu.
Whew.  You can recover from that at least ;)

josh
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help