Re: [net-next-2.6 PATCH] can: SJA1000: generic OF platform bus driver

From: Grant Likely <redacted>
Date: Thu, 21 May 2009 22:42:07 -0600

On Wed, May 20, 2009 at 11:06 AM, Wolfgang Grandegger <wg@grandegger.=

com> wrote:

quoted

This patch adds a generic driver for SJA1000 chips on the OpenFirmwa=

re

quoted

platform bus found on embedded PowerPC systems. You need a SJA1000 n=

ode

quoted

definition in your flattened device tree source (DTS) file similar t=

o:

quoted

=A0 can@3,100 {
=A0 =A0 =A0 =A0 =A0 compatible =3D "philips,sja1000";
=A0 =A0 =A0 =A0 =A0 reg =3D <3 0x100 0x80>;
=A0 =A0 =A0 =A0 =A0 clock-frequency =3D <8000000>;
=A0 =A0 =A0 =A0 =A0 cdr-reg =3D <0x48>;
=A0 =A0 =A0 =A0 =A0 ocr-reg =3D <0x0a>;
=A0 =A0 =A0 =A0 =A0 interrupts =3D <2 0>;
=A0 =A0 =A0 =A0 =A0 interrupt-parent =3D <&mpic>;
=A0 };

=

This new binding must be documented in Documentation/powerpc/dts-bind=

ings

Wolfgang, please add this documentation and resubmit your patch.
Thanks!

David Miller wrote:

From: Grant Likely <redacted>
Date: Thu, 21 May 2009 22:42:07 -0600

quoted

On Wed, May 20, 2009 at 11:06 AM, Wolfgang Grandegger [off-list ref] wrote:

quoted

This patch adds a generic driver for SJA1000 chips on the OpenFirmware
platform bus found on embedded PowerPC systems. You need a SJA1000 node
definition in your flattened device tree source (DTS) file similar to:

  can@3,100 {
          compatible = "philips,sja1000";
          reg = <3 0x100 0x80>;
          clock-frequency = <8000000>;
          cdr-reg = <0x48>;
          ocr-reg = <0x0a>;
          interrupts = <2 0>;
          interrupt-parent = <&mpic>;
  };

This new binding must be documented in Documentation/powerpc/dts-bindings

Wolfgang, please add this documentation and resubmit your patch.
Thanks!

I just sent out v2 incuding the missing documentation.

Thanks,

Wolfgang.