Re: [PATCH 11/14] powerpc: Use macros for .data.page_aligned section.

3 messages, 2 authors, 2009-04-28 · open the first message on its own page

Re: [PATCH 11/14] powerpc: Use macros for .data.page_aligned section.

From: Stephen Rothwell <hidden>
Date: 2009-04-28 15:14:32

Hi Tim,

Firstly, patches for a particular architecture should really be cc'd to
the list associated with that architecture.  In this case,
linuxppc-dev@ozlabs.org (cc'd).

On Mon, 27 Apr 2009 16:33:05 -0400 Tim Abbott [off-list ref] wrote:

quoted hunk

+++ b/arch/powerpc/kernel/vmlinux.lds.S

@@ -222,6 +222,7 @@ SECTIONS
 
 #ifdef CONFIG_PPC32
 	.data : AT(ADDR(.data) - LOAD_OFFSET) {
+		PAGE_ALIGNED_DATA
 		DATA_DATA
 		*(.sdata)
 		*(.got.plt) *(.got)

@@ -259,11 +260,6 @@ SECTIONS
 		*(.data.init_task)
 	}
 
-	. = ALIGN(PAGE_SIZE);
-	.data.page_aligned : AT(ADDR(.data.page_aligned) - LOAD_OFFSET) {
-		*(.data.page_aligned)
-	}
-

This moves the page_aligned section from a common part of the
vmlinux.lds to a 32 bit only part.  Was that intentional?

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

Re: [PATCH 11/14] powerpc: Use macros for .data.page_aligned section.

From: Tim Abbott <hidden>
Date: 2009-04-28 15:16:00

On Wed, 29 Apr 2009, Stephen Rothwell wrote:

This moves the page_aligned section from a common part of the
vmlinux.lds to a 32 bit only part.  Was that intentional?

No.  See my reply to this patch from last night 
<http://lkml.org/lkml/2009/4/28/16> and the revised pair of patches in 
reply to that message that replace PATCH 11/14.

	-Tim Abbott

Re: [PATCH 11/14] powerpc: Use macros for .data.page_aligned section.

From: Stephen Rothwell <hidden>
Date: 2009-04-28 15:18:22

On Wed, 29 Apr 2009 01:07:53 +1000 Stephen Rothwell [off-list ref] wrote:

This moves the page_aligned section from a common part of the
vmlinux.lds to a 32 bit only part.  Was that intentional?

Just saw your later patches, so ignore this.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help