[PATCH -next] fsl_pq_mdio: Revive Gianfar TBI PHY support

Subsystems: networking drivers, the rest

STALE6389d

3 messages, 3 authors, 2009-03-21 · open the first message on its own page

[PATCH -next] fsl_pq_mdio: Revive Gianfar TBI PHY support

From: Anton Vorontsov <hidden>
Date: 2009-03-19 15:52:34

commit 1577ecef766650a57fceb171acee2b13cbfaf1d3 ("netdev: Merge UCC
and gianfar MDIO bus drivers") broke the TSEC TBI PHY support: the
driver now refuses to probe TBI MDIO buses as it doesn't know about
"fsl,gianfar-tbi" compatible entry, and thus _probe() fails with
-ENODEV status.

Fix this by adding "fsl,gianfar-tbi" to the list of known Gianfar
MDIO buses.

Signed-off-by: Anton Vorontsov <redacted>
---
 drivers/net/fsl_pq_mdio.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/fsl_pq_mdio.c b/drivers/net/fsl_pq_mdio.c
index b0ce144..6be36b9 100644
--- a/drivers/net/fsl_pq_mdio.c
+++ b/drivers/net/fsl_pq_mdio.c
@@ -321,6 +321,7 @@ static int fsl_pq_mdio_probe(struct of_device *ofdev,
 	dev_set_drvdata(&ofdev->dev, new_bus);
 
 	if (of_device_is_compatible(np, "fsl,gianfar-mdio") ||
+			of_device_is_compatible(np, "fsl,gianfar-tbi") ||
 			of_device_is_compatible(np, "gianfar")) {
 #ifdef CONFIG_GIANFAR
 		tbipa = get_gfar_tbipa(regs);
-- 
1.5.6.5

Re: [PATCH -next] fsl_pq_mdio: Revive Gianfar TBI PHY support

From: Andy Fleming <hidden>
Date: 2009-03-19 15:57:20

On Mar 19, 2009, at 10:52 AM, Anton Vorontsov wrote:
commit 1577ecef766650a57fceb171acee2b13cbfaf1d3 ("netdev: Merge UCC
and gianfar MDIO bus drivers") broke the TSEC TBI PHY support: the
driver now refuses to probe TBI MDIO buses as it doesn't know about
"fsl,gianfar-tbi" compatible entry, and thus _probe() fails with
-ENODEV status.

Fix this by adding "fsl,gianfar-tbi" to the list of known Gianfar
MDIO buses.

Signed-off-by: Anton Vorontsov <redacted>
Acked-by: Andy Fleming <redacted>

Re: [PATCH -next] fsl_pq_mdio: Revive Gianfar TBI PHY support

From: David Miller <davem@davemloft.net>
Date: 2009-03-21 20:30:29

From: Andy Fleming <redacted>
Date: Thu, 19 Mar 2009 10:56:59 -0500
On Mar 19, 2009, at 10:52 AM, Anton Vorontsov wrote:
quoted
commit 1577ecef766650a57fceb171acee2b13cbfaf1d3 ("netdev: Merge UCC
and gianfar MDIO bus drivers") broke the TSEC TBI PHY support: the
 ...
quoted
Signed-off-by: Anton Vorontsov <redacted>
Acked-by: Andy Fleming <redacted>
Applied
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help