[PATCH] powerpc/cpm2: fix building fs_enet driver as a module.

Subsystems: linux for powerpc (32-bit and 64-bit), the rest

STALE6395d

2 messages, 2 authors, 2009-03-19 · open the first message on its own page

[PATCH] powerpc/cpm2: fix building fs_enet driver as a module.

From: Grant Likely <hidden>
Date: 2009-03-19 04:21:27

From: Grant Likely <redacted>

Building the fs_enet driver as a modules fails because it cannot
access the global cpm2_immr symbol.

Signed-off-by: Grant Likely <redacted>
---

Hey Ben and Kumar,

Just found this while testing some unrelated changes.  Technically
this is a bug fix that should go into 2.6.29, but it looks like an
old problem and probably nobody is getting bitten by it.  I don't
think the world is going to end if it misses the 2.6.29 release.

g.

 arch/powerpc/sysdev/cpm2.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/powerpc/sysdev/cpm2.c b/arch/powerpc/sysdev/cpm2.c
index f1c3395..021480e 100644
--- a/arch/powerpc/sysdev/cpm2.c
+++ b/arch/powerpc/sysdev/cpm2.c
@@ -52,6 +52,7 @@ cpm_cpm2_t __iomem *cpmp; /* Pointer to comm processor space */
  * the communication processor devices.
  */
 cpm2_map_t __iomem *cpm2_immr;
+EXPORT_SYMBOL(cpm2_immr);
 
 #define CPM_MAP_SIZE	(0x40000)	/* 256k - the PQ3 reserve this amount
 					   of space for CPM as it is larger

Re: [PATCH] powerpc/cpm2: fix building fs_enet driver as a module.

From: Kumar Gala <hidden>
Date: 2009-03-19 09:02:32

On Mar 18, 2009, at 11:21 PM, Grant Likely wrote:
From: Grant Likely <redacted>

Building the fs_enet driver as a modules fails because it cannot
access the global cpm2_immr symbol.

Signed-off-by: Grant Likely <redacted>
---

Hey Ben and Kumar,

Just found this while testing some unrelated changes.  Technically
this is a bug fix that should go into 2.6.29, but it looks like an
old problem and probably nobody is getting bitten by it.  I don't
think the world is going to end if it misses the 2.6.29 release.

g.

arch/powerpc/sysdev/cpm2.c |    1 +
1 files changed, 1 insertions(+), 0 deletions(-)
applied to next.  (I agree this isn't worth .29 at this point, if  
anyone cares they can lobby for it in .29.1)

- k
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help