[patch 1/1] powerpc: remove setup_irq(NULL action) in ksi8560

STALE6391d

2 messages, 2 authors, 2009-03-10 · open the first message on its own page

[patch 1/1] powerpc: remove setup_irq(NULL action) in ksi8560

From: Thomas Gleixner <hidden>
Date: 2009-03-10 18:44:19

setup_irq(0, NULL) is broken as setup_irq() dereferences action
unconditionally.

Signed-off-by: Thomas Gleixner <redacted>
CC: Kumar Gala <redacted>
CC: Linux PPC Development <redacted>
---
 arch/powerpc/platforms/85xx/ksi8560.c |    2 --
 1 file changed, 2 deletions(-)

Index: linux-2.6-tip/arch/powerpc/platforms/85xx/ksi8560.c
===================================================================
--- linux-2.6-tip.orig/arch/powerpc/platforms/85xx/ksi8560.c
+++ linux-2.6-tip/arch/powerpc/platforms/85xx/ksi8560.c
@@ -106,8 +106,6 @@ static void __init ksi8560_pic_init(void
 	cpm2_pic_init(np);
 	of_node_put(np);
 	set_irq_chained_handler(irq, cpm2_cascade);
-
-	setup_irq(0, NULL);
 #endif
 }
 

Re: [patch 1/1] powerpc: remove setup_irq(NULL action) in ksi8560

From: Kumar Gala <hidden>
Date: 2009-03-10 18:54:04

On Mar 10, 2009, at 1:43 PM, Thomas Gleixner wrote:
setup_irq(0, NULL) is broken as setup_irq() dereferences action
unconditionally.

Signed-off-by: Thomas Gleixner <redacted>
CC: Kumar Gala <redacted>
CC: Linux PPC Development <redacted>
---
arch/powerpc/platforms/85xx/ksi8560.c |    2 --
1 file changed, 2 deletions(-)
applied to next

- k
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help