RE: ioremap fails for a device in PCI-E slot on AMCC katmai board

Great...That works!!!

Thank you so much.
Shubhada

-----Original Message-----
From: Benjamin Herrenschmidt [mailto:benh@kernel.crashing.org]=20
Sent: Friday, February 20, 2009 8:38 PM
To: Shubhada Pugaonkar
Cc: linuxppc-dev@ozlabs.org
Subject: Re: ioremap fails for a device in PCI-E slot on AMCC katmai
board

On Fri, 2009-02-20 at 17:35 -0800, Shubhada Pugaonkar wrote:

****************************************************
=20
cxgb3_main.c:
=20
        mmio_start =3D pci_resource_start(pdev, 0);
=20
        mmio_len =3D pci_resource_len(pdev, 0);
=20
        ai =3D t3_get_adapter_info(ent->driver_data);
=20

My bet is that mmio_start is an unsigned long instead of a
resource_size_t and thus gets cropped (ie, driver bug).

 (/me goes read the source)

Yes, indeed, that's the problem. Change the definition
of mmio_start and mmio_len to resource_size_t, that should
fix it. I suspect the other driver has the same problem.

Note: They will still get cropped, I suspect, when copied
to netdev->mem_start, nothing much to do here, but fortunately
those fields aren't used.

BTW. If you do patches to fix those drivers, please send them
to the netdev@vger.kernel.org mailing list too.

Cheers,
Ben.