[patch 6/6] mtd/ps3vram: Use msleep in waits

STALE6452d

3 messages, 2 authors, 2009-01-08 · open the first message on its own page

[patch 6/6] mtd/ps3vram: Use msleep in waits

From: Geoff Levand <hidden>
Date: 2009-01-06 21:32:36

Replace the use of udelay() with msleep() in the looping wait routines
ps3vram_notifier_wait() and ps3vram_wait_ring().

Signed-off-by: Geoff Levand <redacted>
---
 drivers/mtd/devices/ps3vram.c |   36 ++++++++++++++----------------------
 1 file changed, 14 insertions(+), 22 deletions(-)

--- a/drivers/mtd/devices/ps3vram.c
+++ b/drivers/mtd/devices/ps3vram.c

@@ -109,22 +109,18 @@ static void ps3vram_notifier_reset(struc
 		notify[i] = 0xffffffff;
 }
 
-static int ps3vram_notifier_wait(struct mtd_info *mtd, int timeout_ms)
+static int ps3vram_notifier_wait(struct mtd_info *mtd, unsigned int timeout_ms)
 {
 	struct ps3vram_priv *priv = mtd->priv;
 	u32 *notify = ps3vram_get_notifier(priv->reports, NOTIFIER);
 
-	timeout_ms *= 1000;
-
 	do {
-		if (notify[3] == 0)
+		if (!notify[3])
 			return 0;
-
-		if (timeout_ms)
-			udelay(1);
+		msleep(1);
 	} while (timeout_ms--);
 
-	return -1;
+	return -ETIMEDOUT;
 }
 
 static void ps3vram_init_ring(struct mtd_info *mtd)

@@ -135,25 +131,21 @@ static void ps3vram_init_ring(struct mtd
 	priv->ctrl[CTRL_GET] = FIFO_BASE + FIFO_OFFSET;
 }
 
-static int ps3vram_wait_ring(struct mtd_info *mtd, int timeout)
+static int ps3vram_wait_ring(struct mtd_info *mtd, unsigned int timeout_ms)
 {
 	struct ps3vram_priv *priv = mtd->priv;
 
-	/* wait until setup commands are processed */
-	timeout *= 1000;
-	while (--timeout) {
+	do {
 		if (priv->ctrl[CTRL_PUT] == priv->ctrl[CTRL_GET])
-			break;
-		udelay(1);
-	}
-	if (timeout == 0) {
-		dev_dbg(priv->dev, "%s:%d: FIFO timeout (%08x/%08x/%08x)\n",
-			__func__, __LINE__, priv->ctrl[CTRL_PUT],
-			priv->ctrl[CTRL_GET], priv->ctrl[CTRL_TOP]);
-		return -ETIMEDOUT;
-	}
+			return 0;
+		msleep(1);
+	} while (timeout_ms--);
 
-	return 0;
+	dev_dbg(priv->dev, "%s:%d: FIFO timeout (%08x/%08x/%08x)\n", __func__,
+		__LINE__, priv->ctrl[CTRL_PUT], priv->ctrl[CTRL_GET],
+		priv->ctrl[CTRL_TOP]);
+
+	return -ETIMEDOUT;
 }
 
 static void ps3vram_out_ring(struct ps3vram_priv *priv, u32 data)

--

Re: [patch 6/6] mtd/ps3vram: Use msleep in waits

From: Arnd Bergmann <arnd@arndb.de>
Date: 2009-01-07 19:25:23

T24gVHVlc2RheSAwNiBKYW51YXJ5IDIwMDksIEdlb2ZmIExldmFuZCB3cm90ZToKPiCgoKCgoKCg
oGRvIHsKPiAtoKCgoKCgoKCgoKCgoKCgaWYgKG5vdGlmeVszXSA9PSAwKQo+ICugoKCgoKCgoKCg
oKCgoKBpZiAoIW5vdGlmeVszXSkKPiCgoKCgoKCgoKCgoKCgoKCgoKCgoKCgoKByZXR1cm4gMDsK
PiAtCj4gLaCgoKCgoKCgoKCgoKCgoGlmICh0aW1lb3V0X21zKQo+IC2goKCgoKCgoKCgoKCgoKCg
oKCgoKCgoHVkZWxheSgxKTsKPiAroKCgoKCgoKCgoKCgoKCgbXNsZWVwKDEpOwo+IKCgoKCgoKCg
fSB3aGlsZSAodGltZW91dF9tcy0tKTsKPiCgCgpJIGd1ZXNzIGl0J3Mgbm90IHJlYWxseSBpbXBv
cnRhbnQsIGJ1dCB0aGlzIGZ1bmN0aW9uIG1pZ2h0IHdhaXQgc3Vic3RhbnRpYWxseQpsb25nZXIg
dGhhbiByZXF1ZXN0ZWQuIElmIHlvdSBoYXZlIENPTkZJR19IWj0xMDAsIG1zbGVlcCgxKSB3aWxs
IHNsZWVwIGZvcgphdCBsZWFzdCAxMCBtaWxpc2Vjb25kcy4gVGhlIGNvcnJlY3Qgd2F5IHRvIHNs
ZWVwIGZvciB1cCB0byBhIGdpdmVuIGFtb3VudApvZiB0aW1lIGlzIHRvIGNhbGN1bGF0ZSB0aGUg
ZW5kIHRpbWUgaW4gamlmZmllcywgYW5kIHVzZSB0aW1lX2JlZm9yZSgpIGluCnRoZSBsb29wIGNv
bmRpdGlvbi4KCglBcm5kIDw+PAo=

[patch 6/6 v2] mtd/ps3vram: Use msleep in waits

From: Geoff Levand <hidden>
Date: 2009-01-08 01:22:02

Subject: [patch] mtd/ps3vram: Use msleep in waits

Replace the use of udelay() with msleep() in the looping wait routines
ps3vram_notifier_wait() and ps3vram_wait_ring().

Signed-off-by: Geoff Levand <redacted>
---
v2: Use time_before() in loops.

 drivers/mtd/devices/ps3vram.c |   40 +++++++++++++++++-----------------------
 1 file changed, 17 insertions(+), 23 deletions(-)

--- a/drivers/mtd/devices/ps3vram.c
+++ b/drivers/mtd/devices/ps3vram.c

@@ -109,22 +109,19 @@ static void ps3vram_notifier_reset(struc
 		notify[i] = 0xffffffff;
 }
 
-static int ps3vram_notifier_wait(struct mtd_info *mtd, int timeout_ms)
+static int ps3vram_notifier_wait(struct mtd_info *mtd, unsigned int timeout_ms)
 {
 	struct ps3vram_priv *priv = mtd->priv;
 	u32 *notify = ps3vram_get_notifier(priv->reports, NOTIFIER);
-
-	timeout_ms *= 1000;
+	unsigned long timeout = jiffies + msecs_to_jiffies(timeout_ms);
 
 	do {
-		if (notify[3] == 0)
+		if (!notify[3])
 			return 0;
+		msleep(1);
+	} while (time_before(jiffies, timeout));
 
-		if (timeout_ms)
-			udelay(1);
-	} while (timeout_ms--);
-
-	return -1;
+	return -ETIMEDOUT;
 }
 
 static void ps3vram_init_ring(struct mtd_info *mtd)

@@ -135,25 +132,22 @@ static void ps3vram_init_ring(struct mtd
 	priv->ctrl[CTRL_GET] = FIFO_BASE + FIFO_OFFSET;
 }
 
-static int ps3vram_wait_ring(struct mtd_info *mtd, int timeout)
+static int ps3vram_wait_ring(struct mtd_info *mtd, unsigned int timeout_ms)
 {
 	struct ps3vram_priv *priv = mtd->priv;
+	unsigned long timeout = jiffies + msecs_to_jiffies(timeout_ms);
 
-	/* wait until setup commands are processed */
-	timeout *= 1000;
-	while (--timeout) {
+	do {
 		if (priv->ctrl[CTRL_PUT] == priv->ctrl[CTRL_GET])
-			break;
-		udelay(1);
-	}
-	if (timeout == 0) {
-		dev_dbg(priv->dev, "%s:%d: FIFO timeout (%08x/%08x/%08x)\n",
-			__func__, __LINE__, priv->ctrl[CTRL_PUT],
-			priv->ctrl[CTRL_GET], priv->ctrl[CTRL_TOP]);
-		return -ETIMEDOUT;
-	}
+			return 0;
+		msleep(1);
+	} while (time_before(jiffies, timeout));
 
-	return 0;
+	dev_dbg(priv->dev, "%s:%d: FIFO timeout (%08x/%08x/%08x)\n", __func__,
+		__LINE__, priv->ctrl[CTRL_PUT], priv->ctrl[CTRL_GET],
+		priv->ctrl[CTRL_TOP]);
+
+	return -ETIMEDOUT;
 }
 
 static void ps3vram_out_ring(struct ps3vram_priv *priv, u32 data)

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help