[PATCH] powerpc: Add MSR[CE, DE] to the MSR bits we print on show_regs()

Subsystems: linux for powerpc (32-bit and 64-bit), the rest · Maintainers: Madhavan Srinivasan, Linus Torvalds

STALE6549d

3 messages, 2 authors, 2008-11-20 · open the first message on its own page

[PATCH] powerpc: Add MSR[CE, DE] to the MSR bits we print on show_regs()

From: Kumar Gala <hidden>
Date: 2008-11-19 14:40:01

Signed-off-by: Kumar Gala <redacted>
---
 arch/powerpc/kernel/process.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/arch/powerpc/kernel/process.c b/arch/powerpc/kernel/process.c
index 957bded..b038323 100644
--- a/arch/powerpc/kernel/process.c
+++ b/arch/powerpc/kernel/process.c
@@ -467,6 +467,8 @@ static struct regbit {
 	{MSR_VEC,	"VEC"},
 	{MSR_VSX,	"VSX"},
 	{MSR_ME,	"ME"},
+	{MSR_CE,	"CE"},
+	{MSR_DE,	"DE"},
 	{MSR_IR,	"IR"},
 	{MSR_DR,	"DR"},
 	{0,		NULL}
-- 
1.5.6.5

Re: [PATCH] powerpc: Add MSR[CE, DE] to the MSR bits we print on show_regs()

From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: 2008-11-20 04:46:48

On Wed, 2008-11-19 at 08:39 -0600, Kumar Gala wrote:
Signed-off-by: Kumar Gala <redacted>
---
Shouldn't this be protected by some ifdef ?

Ben.
quoted hunk
 arch/powerpc/kernel/process.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/arch/powerpc/kernel/process.c b/arch/powerpc/kernel/process.c
index 957bded..b038323 100644
--- a/arch/powerpc/kernel/process.c
+++ b/arch/powerpc/kernel/process.c
@@ -467,6 +467,8 @@ static struct regbit {
 	{MSR_VEC,	"VEC"},
 	{MSR_VSX,	"VSX"},
 	{MSR_ME,	"ME"},
+	{MSR_CE,	"CE"},
+	{MSR_DE,	"DE"},
 	{MSR_IR,	"IR"},
 	{MSR_DR,	"DR"},
 	{0,		NULL}

Re: [PATCH] powerpc: Add MSR[CE, DE] to the MSR bits we print on show_regs()

From: Kumar Gala <hidden>
Date: 2008-11-20 15:31:17

On Nov 19, 2008, at 10:46 PM, Benjamin Herrenschmidt wrote:
On Wed, 2008-11-19 at 08:39 -0600, Kumar Gala wrote:
quoted
Signed-off-by: Kumar Gala <redacted>
---
Shouldn't this be protected by some ifdef ?

Ben.
quoted
arch/powerpc/kernel/process.c |    2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/arch/powerpc/kernel/process.c b/arch/powerpc/kernel/process.c
index 957bded..b038323 100644
--- a/arch/powerpc/kernel/process.c
+++ b/arch/powerpc/kernel/process.c
@@ -467,6 +467,8 @@ static struct regbit {
	{MSR_VEC,	"VEC"},
	{MSR_VSX,	"VSX"},
	{MSR_ME,	"ME"},
+	{MSR_CE,	"CE"},
+	{MSR_DE,	"DE"},
	{MSR_IR,	"IR"},
	{MSR_DR,	"DR"},
	{0,		NULL}
Why?  The bits are always defined and don't seem to be reused (and we don't ifdef VEC, VSX, etc..) so why bother?

- k
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help