Re: powerpc: hv{cs,si}_close() both unsigned hp->count and hvcsd->open_count cannot be negative

roel kluin [off-list ref] writes:

This is not the same.

Likewise.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Andreas Schwab wrote:

roel kluin [off-list ref] writes:

quoted

-	if (--hvcsd->open_count == 0) {
+	if (hvcsd->open_count == 1) {
+		hvcsd->open_count--;

This is not the same.

I think you're missing that I also decrement if (hvcsd->open_count > 1)
If not, please elaborate.

quoted

-	if (--hp->count == 0) {
+	if (hp->count == 1) {
+		hp->count--;

Likewise.

Same here.

Roel