# Re: \[PATCH\] IB/ehca: Fix lockdep failures for shca\_list\_lock

- From: Michael Ellerman \<hidden\>
- Date: 2008-11-22 03:41:47 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2008/11/1177567
- Thread: https://ratatoskr.run/lkml/2008/06/1109740/t.md

```text
On Fri, 2008-11-21 at 17:02 +0100, Johannes Berg wrote:
> On Fri, 2008-11-21 at 16:37 +0100, Joachim Fenkes wrote:
> 
> > +	u64 flags;
> 
> > -	spin_lock(&shca_list_lock);
> > +	spin_lock_irqsave(&shca_list_lock, flags);
> 
> That's wrong and I think will give a warning on all machines where
> u64 != unsigned long. Might not particularly matter in this case.

Crud, sorry.

> Also, generally it seems wrong to say "fix lockdep failure" when the
> patch really fixes a bug that lockdep happened to find.

True. I guess it should be "fix locking error found with lockdep", to
make it clear no one has actually hit the bug.

cheers

-- 
Michael Ellerman
OzLabs, IBM Australia Development Lab

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person
```

## Attachments

- [signature.asc](https://ratatoskr.run/linuxppc-dev/2008/11/1177567/attachment/0) (application/pgp-signature, 197 bytes)