Re: [PATCH] Fix msr check in compat_sys_swapcontext

2 messages, 2 authors, 2008-11-06 · open the first message on its own page

Re: [PATCH] Fix msr check in compat_sys_swapcontext

From: Andreas Schwab <hidden>
Date: 2008-11-06 09:23:29

Paul Mackerras [off-list ref] writes:
we need to use get_user, not __get_user, since we haven't done an
access_ok() check on the address.
The address is always ok since its a compat pointer, see do_setcontext.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: [PATCH] Fix msr check in compat_sys_swapcontext

From: Paul Mackerras <hidden>
Date: 2008-11-06 10:40:45

Andreas Schwab writes:
Paul Mackerras [off-list ref] writes:
quoted
we need to use get_user, not __get_user, since we haven't done an
access_ok() check on the address.
The address is always ok since its a compat pointer, see do_setcontext.
OK, since it's inside a CONFIG_PPC64 block.  I'll add a paragraph to
the patch description pointing that out.

Paul.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help