[PATCH 1/2] OF: add fsl,mcu-mpc8349emitx to the exception list

Subsystems: open firmware and flattened device tree, the rest · Maintainers: Rob Herring, Saravana Kannan, Linus Torvalds

STALE6592d

8 messages, 4 authors, 2008-10-10 · open the first message on its own page

[PATCH 1/2] OF: add fsl,mcu-mpc8349emitx to the exception list

From: Anton Vorontsov <hidden>
Date: 2008-09-23 14:12:56

of/base.c matches on the first (most specific) entries, which isn't
quite practical but it was discussed[1] that this won't change.

The bindings specifies verbose information for the devices, but
it doesn't fit in the I2C ID's 20 characters limit. The limit won't
change[2], and the bindings won't change either as they're correct.

So we have to put an exception for the MPC8349E-mITX-compatible
MCUs.

[1] http://www.mail-archive.com/linuxppc-dev@ozlabs.org/msg21196.html
[2] http://www.nabble.com/-PATCH-1-2--i2c:-expand-I2C's-id.name-to-23-characters-td19577063.html

Signed-off-by: Anton Vorontsov <redacted>
---
 drivers/of/base.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/of/base.c b/drivers/of/base.c
index ad8ac1a..a726464 100644
--- a/drivers/of/base.c
+++ b/drivers/of/base.c
@@ -410,7 +410,7 @@ struct of_modalias_table {
 	char *modalias;
 };
 static struct of_modalias_table of_modalias_table[] = {
-	/* Empty for now; add entries as needed */
+	{ "fsl,mcu-mpc8349emitx", "mcu-mpc8349emitx" },
 };
 
 /**
-- 
1.5.6.3

Re: [PATCH 1/2] OF: add fsl,mcu-mpc8349emitx to the exception list

From: Anton Vorontsov <hidden>
Date: 2008-09-30 12:44:27

On Tue, Sep 23, 2008 at 06:12:19PM +0400, Anton Vorontsov wrote:
of/base.c matches on the first (most specific) entries, which isn't
quite practical but it was discussed[1] that this won't change.

The bindings specifies verbose information for the devices, but
it doesn't fit in the I2C ID's 20 characters limit. The limit won't
change[2], and the bindings won't change either as they're correct.

So we have to put an exception for the MPC8349E-mITX-compatible
MCUs.

[1] http://www.mail-archive.com/linuxppc-dev@ozlabs.org/msg21196.html
[2] http://www.nabble.com/-PATCH-1-2--i2c:-expand-I2C's-id.name-to-23-characters-td19577063.html

Signed-off-by: Anton Vorontsov <redacted>
---
 drivers/of/base.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Any issues with this or the second patch? Can we merge them?


Thanks,
quoted hunk
diff --git a/drivers/of/base.c b/drivers/of/base.c
index ad8ac1a..a726464 100644
--- a/drivers/of/base.c
+++ b/drivers/of/base.c
@@ -410,7 +410,7 @@ struct of_modalias_table {
 	char *modalias;
 };
 static struct of_modalias_table of_modalias_table[] = {
-	/* Empty for now; add entries as needed */
+	{ "fsl,mcu-mpc8349emitx", "mcu-mpc8349emitx" },
 };
 
 /**
-- 
1.5.6.3
-- 
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2

Re: [PATCH 1/2] OF: add fsl,mcu-mpc8349emitx to the exception list

From: Jean Delvare <hidden>
Date: 2008-10-01 11:23:15

Hi Anton,

On Tue, 30 Sep 2008 16:44:24 +0400, Anton Vorontsov wrote:
On Tue, Sep 23, 2008 at 06:12:19PM +0400, Anton Vorontsov wrote:
quoted
of/base.c matches on the first (most specific) entries, which isn't
quite practical but it was discussed[1] that this won't change.

The bindings specifies verbose information for the devices, but
it doesn't fit in the I2C ID's 20 characters limit. The limit won't
change[2], and the bindings won't change either as they're correct.

So we have to put an exception for the MPC8349E-mITX-compatible
MCUs.

[1] http://www.mail-archive.com/linuxppc-dev@ozlabs.org/msg21196.html
[2] http://www.nabble.com/-PATCH-1-2--i2c:-expand-I2C's-id.name-to-23-characters-td19577063.html

Signed-off-by: Anton Vorontsov <redacted>
---
 drivers/of/base.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Any issues with this or the second patch? Can we merge them?
I do not have the time to review these patches (and, honestly, have no
interest in them.) So I will not merge them but I have no objection to
them being merged by somebody else.

-- 
Jean Delvare

Re: [PATCH 1/2] OF: add fsl,mcu-mpc8349emitx to the exception list

From: Anton Vorontsov <hidden>
Date: 2008-10-01 11:39:51

On Wed, Oct 01, 2008 at 01:22:48PM +0200, Jean Delvare wrote:
Hi Anton,

On Tue, 30 Sep 2008 16:44:24 +0400, Anton Vorontsov wrote:
quoted
On Tue, Sep 23, 2008 at 06:12:19PM +0400, Anton Vorontsov wrote:
quoted
of/base.c matches on the first (most specific) entries, which isn't
quite practical but it was discussed[1] that this won't change.

The bindings specifies verbose information for the devices, but
it doesn't fit in the I2C ID's 20 characters limit. The limit won't
change[2], and the bindings won't change either as they're correct.

So we have to put an exception for the MPC8349E-mITX-compatible
MCUs.

[1] http://www.mail-archive.com/linuxppc-dev@ozlabs.org/msg21196.html
[2] http://www.nabble.com/-PATCH-1-2--i2c:-expand-I2C's-id.name-to-23-characters-td19577063.html

Signed-off-by: Anton Vorontsov <redacted>
---
 drivers/of/base.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Any issues with this or the second patch? Can we merge them?
I do not have the time to review these patches (and, honestly, have no
interest in them.) So I will not merge them but I have no objection to
them being merged by somebody else.
Ok, thanks for the sincerity.. ;-)

Kumar, could you pick up the two patches via the patchworks?

[1/2] OF: add fsl,mcu-mpc8349emitx to the exception list
http://patchwork.ozlabs.org/patch/1105/

[2/2] i2c: MPC8349E-mITX Power Management and GPIO expander driver
http://patchwork.ozlabs.org/patch/1106/

Or should I resend them to you? Or should I resend them to Andrew?


Thanks,

-- 
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2

Re: [PATCH 1/2] OF: add fsl,mcu-mpc8349emitx to the exception list

From: Anton Vorontsov <hidden>
Date: 2008-10-06 17:28:33

On Wed, Oct 01, 2008 at 03:39:48PM +0400, Anton Vorontsov wrote:
[...]
quoted
quoted
Any issues with this or the second patch? Can we merge them?
I do not have the time to review these patches (and, honestly, have no
interest in them.) So I will not merge them but I have no objection to
them being merged by somebody else.
Ok, thanks for the sincerity.. ;-)

Kumar, could you pick up the two patches via the patchworks?

[1/2] OF: add fsl,mcu-mpc8349emitx to the exception list
http://patchwork.ozlabs.org/patch/1105/

[2/2] i2c: MPC8349E-mITX Power Management and GPIO expander driver
http://patchwork.ozlabs.org/patch/1106/

Or should I resend them to you? Or should I resend them to Andrew?
Ping?

-- 
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2

Re: [PATCH 1/2] OF: add fsl,mcu-mpc8349emitx to the exception list

From: Grant Likely <hidden>
Date: 2008-10-06 17:32:02

On Mon, Oct 06, 2008 at 09:28:31PM +0400, Anton Vorontsov wrote:
On Wed, Oct 01, 2008 at 03:39:48PM +0400, Anton Vorontsov wrote:
[...]
quoted
quoted
quoted
Any issues with this or the second patch? Can we merge them?
I do not have the time to review these patches (and, honestly, have no
interest in them.) So I will not merge them but I have no objection to
them being merged by somebody else.
Ok, thanks for the sincerity.. ;-)

Kumar, could you pick up the two patches via the patchworks?

[1/2] OF: add fsl,mcu-mpc8349emitx to the exception list
http://patchwork.ozlabs.org/patch/1105/
Since I've been involved with the i2c of bindings, I can pick this one up.
quoted
[2/2] i2c: MPC8349E-mITX Power Management and GPIO expander driver
http://patchwork.ozlabs.org/patch/1106/
But I'm not involved enough with this one, so it should go through
kumar.

g.

Re: [PATCH 1/2] OF: add fsl,mcu-mpc8349emitx to the exception list

From: Anton Vorontsov <hidden>
Date: 2008-10-06 18:44:04

On Mon, Oct 06, 2008 at 11:31:58AM -0600, Grant Likely wrote:
On Mon, Oct 06, 2008 at 09:28:31PM +0400, Anton Vorontsov wrote:
quoted
On Wed, Oct 01, 2008 at 03:39:48PM +0400, Anton Vorontsov wrote:
[...]
quoted
quoted
quoted
Any issues with this or the second patch? Can we merge them?
I do not have the time to review these patches (and, honestly, have no
interest in them.) So I will not merge them but I have no objection to
them being merged by somebody else.
Ok, thanks for the sincerity.. ;-)

Kumar, could you pick up the two patches via the patchworks?

[1/2] OF: add fsl,mcu-mpc8349emitx to the exception list
http://patchwork.ozlabs.org/patch/1105/
Since I've been involved with the i2c of bindings, I can pick this one up.
Much appreciated, thanks!
quoted
quoted
[2/2] i2c: MPC8349E-mITX Power Management and GPIO expander driver
http://patchwork.ozlabs.org/patch/1106/
But I'm not involved enough with this one, so it should go through
kumar.
That's fine, the first and second patches could go separate trees
since it won't break the build.

-- 
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2

Re: [PATCH 1/2] OF: add fsl,mcu-mpc8349emitx to the exception list

From: Kumar Gala <hidden>
Date: 2008-10-10 14:27:47

On Sep 23, 2008, at 9:12 AM, Anton Vorontsov wrote:
of/base.c matches on the first (most specific) entries, which isn't
quite practical but it was discussed[1] that this won't change.

The bindings specifies verbose information for the devices, but
it doesn't fit in the I2C ID's 20 characters limit. The limit won't
change[2], and the bindings won't change either as they're correct.

So we have to put an exception for the MPC8349E-mITX-compatible
MCUs.

[1] http://www.mail-archive.com/linuxppc-dev@ozlabs.org/msg21196.html
[2] http://www.nabble.com/-PATCH-1-2--i2c:-expand-I2C's-id.name-to-23-characters-td19577063.html

Signed-off-by: Anton Vorontsov <redacted>
---
drivers/of/base.c |    2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
applied.

- k
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help