RE: [PATCH] Linux Device Driver for Xilinx LL TEMAC 10/100/1000 EthernetNIC

I screwed up and forgot to copy all on this previously.

-----Original Message-----
From: David H. Lynch Jr. [mailto:<redacted>]
Sent: Tuesday, August 19, 2008 3:19 PM
To: John Linn
Subject: Re: [PATCH] Linux Device Driver for Xilinx LL TEMAC

10/100/1000 EthernetNIC

=

John Linn wrote:

quoted

quoted

    Stephen wants OF support -which is fine,  but I can not test

that.

quoted

quoted

I definitely agree with Stephen that OF support is needed since

arch/ppc

quoted

has gone away. We aren't doing any new work on arch/ppc.

Are you not planning to move to arch/powerpc anytime soon?  I could

help

quoted

you with that transition which would be better in the long run.  I'd
rather do that than do testing for you as I think it would be more
productive, but I've been wrong before.

=

We will move to powerpc, but not in the time-frame I am hoping for

this

driver.
In the context of Linux and Pico, "we" means me, and there is no time

to

do the work anytime soon.
=

<snip>

What about you getting all the review & testing done and then we
(Xilinx) will add the OF support to the driver? =


I doubt the powerpc mainline will take the driver without OF support. In
fact, we had to remove the platform bus support from the last driver
that we put into mainline for arch/powerpc.

=

quoted

quoted

I would like
    one and only one tag that can be used end-end.

    Is there something xilinx will object to ? Prefer ? ....

xilinx_<device name>, (xilinx_lltemac or xilinx_ps2) is what we use

for

quoted

file names. The device tree does use "xlnx" to identify xilinx

devices,

quoted

but I don't think that should dictate file names.

We have a driver in out GIT tree that is not flat (as most know) for

the

quoted

LL TEMAC and we are working on creating flat drivers for future

devices.

quoted

Ideally this new driver would be a replacement for our driver.

=

Give me a name and I will go with it. the xps_lltemac name came from
Yoshio,
It is not in stone.
=

If I name the module "xilinx_lltemac" and go with xilinx_lltemac.c for
the file name,
is that going to cause problems with xilinx ?
=

I will use whatever you recomend.

xilinx_lltemac is the preferred. =


I don't think using xilinx_lltemac should cause problems.  Our Xilinx
Git tree has a xilinx_lltemac subdir that contains the non-flat driver
but that should be ok with your xilinx_lltemac.c file in the net
directory.

=

--
Dave Lynch 					  	    DLA Systems
Software Development:

Embedded Linux

717.627.3770 	       dhlii@dlasys.net 	  http://www.dlasys.net
fax: 1.253.369.9244 			           Cell: 1.717.587.7774
Over 25 years' experience in platforms, languages, and technologies

too numerous to list.

=

"Any intelligent fool can make things bigger and more complex... It

takes a touch of genius - and a

lot of courage to move in the opposite direction."
Albert Einstein
=

This email and any attachments are intended for the sole use of the named r=
ecipient(s) and contain(s) confidential information that may be proprietary=
, privileged or copyrighted under applicable law. If you are not the intend=
ed recipient, do not read, copy, or forward this email message or any attac=
hments. Delete this email message and any attachments immediately.

John Linn wrote:

What about you getting all the review & testing done and then we
(Xilinx) will add the OF support to the driver? 

I doubt the powerpc mainline will take the driver without OF support. In
fact, we had to remove the platform bus support from the last driver
that we put into mainline for arch/powerpc.
  

That is perfectly fine with me. i will try to pull the xilinx git tree
and see how much closer I can make the probe so that converting will be
easier.

xilinx_lltemac is the preferred. 

I don't think using xilinx_lltemac should cause problems.  Our Xilinx
Git tree has a xilinx_lltemac subdir that contains the non-flat driver
but that should be ok with your xilinx_lltemac.c file in the net
directory.
  

The next patch incarnation will have everything as xilinx_lltemac -
including the file as xilinx_lltemac.c

-- 
Dave Lynch 					  	    DLA Systems
Software Development:  				         Embedded Linux
717.627.3770 	       dhlii@dlasys.net 	  http://www.dlasys.net
fax: 1.253.369.9244 			           Cell: 1.717.587.7774
Over 25 years' experience in platforms, languages, and technologies too numerous to list.

"Any intelligent fool can make things bigger and more complex... It takes a touch of genius - and a lot of courage to move in the opposite direction."
Albert Einstein