[PATCH v2] Add MPC5200B base board mvBC-P

STALE6598d

4 messages, 3 authors, 2008-07-09 · open the first message on its own page

[PATCH v2] Add MPC5200B base board mvBC-P

From: Andre Schwarz <hidden>
Date: 2008-07-07 08:14:31

The mvBlueCOUGAR-P is a MPC5200B based camera system with Intel Gigabit ethernet
controller (using e1000). It's just another MPC5200_simple board.

Signed-off-by: Andre Schwarz <redacted>
---



Grant,

please find attached the re-submitted patch with mods as you requested.
I've also fixed the dts regarding to David's proposal.

Please let me know if anything is still incorrect.

Thanks again,
Andre



MATRIX VISION GmbH, Talstraße 16, DE-71570 Oppenweiler  - Registergericht: Amtsgericht Stuttgart, HRB 271090
Geschäftsführer: Gerhard Thullner, Werner Armingeon, Uwe Furtner

Re: [PATCH v2] Add MPC5200B base board mvBC-P

From: David Gibson <hidden>
Date: 2008-07-08 03:44:27

On Mon, Jul 07, 2008 at 10:14:29AM +0200, Andre Schwarz wrote:
The mvBlueCOUGAR-P is a MPC5200B based camera system with Intel Gigabit ethernet
controller (using e1000). It's just another MPC5200_simple board.
[snip]
+		timer@600 {	// General Purpose Timer
+			compatible = "fsl,mpc5200b-gpt","fsl,mpc5200-gpt";
+			reg = <0x600 0x10>;
+			interrupts = <1 9 0>;
+			interrupt-parent = <&mpc5200_pic>;
+			fsl,has-wdt;
+		};
+
+		timer@610 {	// General Purpose Timer
+			compatible = "fsl,mpc5200b-gpt","fsl,mpc5200-gpt";
+			cell-index = <1>;
What shared resource is this cell-index value used to index?

Also why does it not appear on the timer@600 but does on all the
others.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

Re: [PATCH v2] Add MPC5200B base board mvBC-P

From: Andre Schwarz <hidden>
Date: 2008-07-08 08:30:03

David Gibson schrieb:
On Mon, Jul 07, 2008 at 10:14:29AM +0200, Andre Schwarz wrote:
  
quoted
The mvBlueCOUGAR-P is a MPC5200B based camera system with Intel Gigabit ethernet
controller (using e1000). It's just another MPC5200_simple board.
    
[snip]
  
quoted
+		timer@600 {	// General Purpose Timer
+			compatible = "fsl,mpc5200b-gpt","fsl,mpc5200-gpt";
+			reg = <0x600 0x10>;
+			interrupts = <1 9 0>;
+			interrupt-parent = <&mpc5200_pic>;
+			fsl,has-wdt;
+		};
+
+		timer@610 {	// General Purpose Timer
+			compatible = "fsl,mpc5200b-gpt","fsl,mpc5200-gpt";
+			cell-index = <1>;
    
What shared resource is this cell-index value used to index?

Also why does it not appear on the timer@600 but does on all the
others.

  
Sorry - it's a copy paste problem. At first I only used timer0, i.e.
this is the original entry.
After Grant wanting me to have a look at the lite5200b.dts I copied over
the rest of the dts nodes I also have on my board. On lite5200b.dts the
cell-index is defined.

If this is incorrect I'll remove it.
Is cell-index inappropriate for the timer node ?


regards,
Andre


MATRIX VISION GmbH, Talstraße 16, DE-71570 Oppenweiler  - Registergericht: Amtsgericht Stuttgart, HRB 271090
Geschäftsführer: Gerhard Thullner, Werner Armingeon, Uwe Furtner

Re: [PATCH v2] Add MPC5200B base board mvBC-P

From: Grant Likely <hidden>
Date: 2008-07-09 00:54:14

On Tue, Jul 08, 2008 at 10:30:00AM +0200, Andre Schwarz wrote:
David Gibson schrieb:
quoted
On Mon, Jul 07, 2008 at 10:14:29AM +0200, Andre Schwarz wrote:
  
quoted
The mvBlueCOUGAR-P is a MPC5200B based camera system with Intel Gigabit ethernet
controller (using e1000). It's just another MPC5200_simple board.
    
[snip]
  
quoted
+		timer@600 {	// General Purpose Timer
+			compatible = "fsl,mpc5200b-gpt","fsl,mpc5200-gpt";
+			reg = <0x600 0x10>;
+			interrupts = <1 9 0>;
+			interrupt-parent = <&mpc5200_pic>;
+			fsl,has-wdt;
+		};
+
+		timer@610 {	// General Purpose Timer
+			compatible = "fsl,mpc5200b-gpt","fsl,mpc5200-gpt";
+			cell-index = <1>;
    
What shared resource is this cell-index value used to index?

Also why does it not appear on the timer@600 but does on all the
others.

  
Sorry - it's a copy paste problem. At first I only used timer0, i.e.
this is the original entry.
After Grant wanting me to have a look at the lite5200b.dts I copied over
the rest of the dts nodes I also have on my board. On lite5200b.dts the
cell-index is defined.

If this is incorrect I'll remove it.
Is cell-index inappropriate for the timer node ?
Yes, you can drop cell-index for fsl,mpc5200-gpt nodes.

g.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help