[POWERPC] mpc7448hpc2.dts: remove chosen node from dts

3 messages, 3 authors, 2008-06-30 · open the first message on its own page

[POWERPC] mpc7448hpc2.dts: remove chosen node from dts

From: Chunbo Luo <hidden>
Date: 2008-06-30 07:20:26

=EF=BB=BFModern versions of u-boot create a chosen node automatically.  So =
if
we set the chosen node in the dts file, there will be 2 chosen nodes
passed in to the kernel, and the kernel command line will be taken from
the wrong node.  So, remove the extra chosen node from the dts file.

=EF=BB=BFSigned-off-by: Chunbo Luo [off-list ref]

---
 arch/powerpc/boot/dts/mpc7448hpc2.dts |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/arch/powerpc/boot/dts/mpc7448hpc2.dts
b/arch/powerpc/boot/dts/mpc7448hpc2.dts
index 4936349..d74727f 100644
--- a/arch/powerpc/boot/dts/mpc7448hpc2.dts
+++ b/arch/powerpc/boot/dts/mpc7448hpc2.dts
@@ -186,8 +186,5 @@
 			};
 		};
 	};
-	chosen {
-		linux,stdout-path =3D "/tsi108@c0000000/serial@7808";
-	};
=20
 };
---

Re: [POWERPC] mpc7448hpc2.dts: remove chosen node from dts

From: Segher Boessenkool <hidden>
Date: 2008-06-30 16:22:26

Modern versions of u-boot create a chosen node automatically.  So if
we set the chosen node in the dts file, there will be 2 chosen nodes
passed in to the kernel,
That's a bug in uboot, then: when it creates a property, it should
delete an already existing property with the same name in that node.
and the kernel command line will be taken from
the wrong node.  So, remove the extra chosen node from the dts file.
This will cause a regression for people using an older version of
uboot.  No idea how important that is.


Segher

Re: [POWERPC] mpc7448hpc2.dts: remove chosen node from dts

From: Scott Wood <hidden>
Date: 2008-06-30 18:46:34

Segher Boessenkool wrote:
quoted
Modern versions of u-boot create a chosen node automatically.  So if
we set the chosen node in the dts file, there will be 2 chosen nodes
passed in to the kernel,
That's a bug in uboot, then:
Yes, and it was fixed a while ago.

-Scott
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help