# RE: \[PATCH 1/4\] \[v4\]\[POWERPC\] refactor dcr code

- From: Stephen Neuendorffer \<hidden\>
- Date: 2008-05-06 17:34:46 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2008/05/9439795
- Thread: https://ratatoskr.run/linuxppc-dev/2008/05/9439721/t.md

```text

I'll fix it.

> -----Original Message-----
> From: Benjamin Herrenschmidt [mailto:benh@kernel.crashing.org]
> Sent: Monday, May 05, 2008 9:02 PM
> To: Stephen Rothwell
> Cc: Stephen Neuendorffer; <redacted>;
grant.likely@secretlab.ca; linuxppc-
> dev@ozlabs.org
> Subject: Re: [PATCH 1/4] [v4][POWERPC] refactor dcr code
>=20
>=20
> On Tue, 2008-05-06 at 13:40 +1000, Stephen Rothwell wrote:
> > Since find_dcr_parent has done a of_node_get on its return value,
you
> > leak a reference to dp here i.e. you need an of_node_put(dp) before
> > you return.
>=20
> He inherited that bug from other dcr.c functions I wrote, my fault.
>=20
> Stephen (N. not R.), would you mind fixing them while at it or do you
> want me to cook up a patch ?
>=20
> Cheers,
> Ben.
>=20
>=20
```