[PATCH] [POWERPC] Fix of_i2c include for module compilation
From: Jochen Friedrich <jochen@scram.de>
Date: 2008-05-03 12:43:22
Subsystems: open firmware and flattened device tree, the rest · Maintainers: Rob Herring, Saravana Kannan, Linus Torvalds
3 messages, 2 authors, 2008-05-06 · open the first message on its own page
From: Jochen Friedrich <jochen@scram.de>
Date: 2008-05-03 12:43:22
Now that of_i2c may be compiled as module, the header must be exported for module compilation, as well. Signed-off-by: Jochen Friedrich <jochen@scram.de> --- include/linux/of_i2c.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/linux/of_i2c.h b/include/linux/of_i2c.h
index 2e5a967..dca6013 100644
--- a/include/linux/of_i2c.h
+++ b/include/linux/of_i2c.h@@ -14,7 +14,7 @@ #include <linux/i2c.h> -#ifdef CONFIG_OF_I2C +#if defined(CONFIG_OF_I2C) || defined(CONFIG_OF_I2C_MODULE) void of_register_i2c_devices(struct i2c_adapter *adap, struct device_node *adap_node);
--
1.5.5.1
From: Paul Mackerras <hidden>
Date: 2008-05-05 04:24:53
Jochen Friedrich writes:
-#ifdef CONFIG_OF_I2C +#if defined(CONFIG_OF_I2C) || defined(CONFIG_OF_I2C_MODULE) void of_register_i2c_devices(struct i2c_adapter *adap, struct device_node *adap_node);
Why do we have that ifdef there at all? There's only that one external declaration within it, so the #ifdef and #endif could just be removed. If the ifdef hadn't been there in the first place we wouldn't have had this problem. Paul.
From: Jochen Friedrich <jochen@scram.de>
Date: 2008-05-06 18:39:58
Hi Paul,
quoted
-#ifdef CONFIG_OF_I2C +#if defined(CONFIG_OF_I2C) || defined(CONFIG_OF_I2C_MODULE) void of_register_i2c_devices(struct i2c_adapter *adap, struct device_node *adap_node);Why do we have that ifdef there at all? There's only that one external declaration within it, so the #ifdef and #endif could just be removed. If the ifdef hadn't been there in the first place we wouldn't have had this problem.
You're right. I mainly copied from of_gpio.h without too much thinking :(. I'll resend. Thanks, Jochen