# Re: \[PATCH v2\] 8xx: Add support for the MPC852 based board from keymile.

- From: Stephen Rothwell \<hidden\>
- Date: 2008-03-18 07:36:42 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2008/03/9436920
- Thread: https://ratatoskr.run/linuxppc-dev/2008/03/9436829/t.md

```text
Hi Heiko,

On Tue, 18 Mar 2008 08:13:06 +0100 Heiko Schocher [ref] wrote:
>
> Stephen Rothwell wrote:
> > On Fri, 14 Mar 2008 10:24:30 +0100 Heiko Schocher [ref] wrote:
> [...]
> >> +struct cpm_pin {
> >> +		int port, pin, flags;
> >> +};
> > 
> > I wish someone would consolidate all these definitions of cpm_pin.
> 
> Hmm... do you mean something like, moving this struct
> in cpm1.h and ...

Yes or somewhere else appropriate.

> >> +	for (i = 0; i < ARRAY_SIZE(mgsuvd_pins); i++) {
> >> +		struct cpm_pin *pin = &mgsuvd_pins[i];
> >> +		cpm1_set_pin(pin->port, pin->pin, pin->flags);
> >> +	}
> > 
> > And the code that uses them ...
> 
> making in arch/powerpc/sysdev/cpm1.c a function
> cpm1_setup_pins (struct cpm_pin *pins) ?

Yes.

This is not necessary for your patch, but would be a nice cleanup later.
N.B. this struct is alos used by users of cpm2_set_pin().

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
```

## Attachments

- [(unnamed)](https://ratatoskr.run/linuxppc-dev/2008/03/9436920/attachment/0) (application/pgp-signature, 189 bytes)