# Re: \[PATCH 1/2 v3\] Driver for Freescale 8610 and 5121 DIU

- From: Andrew Morton \<akpm@linux-foundation.org\>
- Date: 2008-03-27 07:54:39 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2008/03/1079223
- Thread: https://ratatoskr.run/lkml/2008/03/1078479/t.md

```text
On Tue, 25 Mar 2008 16:27:17 -0500 York Sun [ref] wrote:

> +#if defined(CONFIG_NOT_COHERENT_CACHE)
> +unsigned int *coherence_data;
> +phys_addr_t *coherence_data_phy;
> +#endif

These identifiers are too general for use as global symbols.  I'd suggest
renaming them to diu_coherence_data and diu_coherence_data_phy.  Or make
them static - I didn't check.

I'll duck this version of the patches, as Scott's comments looked rather
substantial.
```