From: Anton Vorontsov <hidden> Date: 2008-02-21 19:50:22
Without this patch it's impossible to select ehci-fsl on PPC_MPC837x.
Another option would be to convert USB_EHCI_FSL to verbose bool,
but I presume EHCI_FSL is purposely made silent.
Signed-off-by: Anton Vorontsov <redacted>
---
drivers/usb/host/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
From: Scott Wood <hidden> Date: 2008-02-21 19:54:41
Anton Vorontsov wrote:
Without this patch it's impossible to select ehci-fsl on PPC_MPC837x.
Another option would be to convert USB_EHCI_FSL to verbose bool,
but I presume EHCI_FSL is purposely made silent.
I think making it verbose bool would be better.
-Scott
From: Kumar Gala <hidden> Date: 2008-02-21 19:58:25
On Feb 21, 2008, at 1:50 PM, Anton Vorontsov wrote:
quoted hunk
Without this patch it's impossible to select ehci-fsl on PPC_MPC837x.
Another option would be to convert USB_EHCI_FSL to verbose bool,
but I presume EHCI_FSL is purposely made silent.
Signed-off-by: Anton Vorontsov <redacted>
---
drivers/usb/host/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
From: Scott Wood <hidden> Date: 2008-02-21 20:09:01
Kumar Gala wrote:
On Feb 21, 2008, at 1:50 PM, Anton Vorontsov wrote:
quoted
Without this patch it's impossible to select ehci-fsl on PPC_MPC837x.
Another option would be to convert USB_EHCI_FSL to verbose bool,
but I presume EHCI_FSL is purposely made silent.
Signed-off-by: Anton Vorontsov <redacted>
---
drivers/usb/host/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
bool
depends on USB_EHCI_HCD
select USB_EHCI_ROOT_HUB_TT
- default y if MPC834x || PPC_MPC831x
+ default y if MPC834x || PPC_MPC831x || PPC_MPC837x
Can we just change this to FSL_SOC
Why do you want to bloat all freescale kernels, even on chips that don't
have this hardware?
There are very few cases where default y is justified. This isn't one
of them.
-Scott
From: Anton Vorontsov <hidden> Date: 2008-02-21 20:31:00
On Thu, Feb 21, 2008 at 01:58:18PM -0600, Kumar Gala wrote:
On Feb 21, 2008, at 1:50 PM, Anton Vorontsov wrote:
quoted
Without this patch it's impossible to select ehci-fsl on PPC_MPC837x.
Another option would be to convert USB_EHCI_FSL to verbose bool,
but I presume EHCI_FSL is purposely made silent.
Signed-off-by: Anton Vorontsov <redacted>
---
drivers/usb/host/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
bool
depends on USB_EHCI_HCD
select USB_EHCI_ROOT_HUB_TT
- default y if MPC834x || PPC_MPC831x
+ default y if MPC834x || PPC_MPC831x || PPC_MPC837x
Can we just change this to FSL_SOC
Easily. But not "default y"... "depends on" instead, ok?
There are plenty of FSL chips without EHCI built-in, so with
default y we'll enable it wrongly.
- - - -
From: Anton Vorontsov <redacted>
Subject: [USB POWERPC] ehci-fsl: handles other freescale processors
This patch converts USB_EHCI_FSL config option into the verbose
bool, so we'll able to select it for other freescale processors
with built-in EHCI controller.
Signed-off-by: Anton Vorontsov <redacted>
---
drivers/usb/host/Kconfig | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
From: Peter Korsgaard <jacmet@sunsite.dk> Date: 2008-02-22 01:36:32
quoted
quoted
quoted
quoted
"Anton" == Anton Vorontsov [off-list ref] writes:
Hi,
Anton> config USB_EHCI_FSL
Anton> - bool
Anton> - depends on USB_EHCI_HCD
Anton> + bool "Support for Freescale on-chip EHCI USB controller"
Anton> + depends on USB_EHCI_HCD && FSL_SOC
Anton> select USB_EHCI_ROOT_HUB_TT
Anton> - default y if MPC834x || PPC_MPC831x
Notice that I have a patch in the USB queue which fixes up the MPC834x
symbol (PPC_MPC834x instead of MPC834x) so this patch won't apply.
--
Bye, Peter Korsgaard