[PATCH] drivers/base: export gpl (un)register_memory_notifier

Subsystems: driver core, kobjects, debugfs and sysfs, memory hot(un)plug, the rest

STALE6749d

3 messages, 3 authors, 2008-02-11 · open the first message on its own page

[PATCH] drivers/base: export gpl (un)register_memory_notifier

From: Jan-Bernd Themann <hidden>
Date: 2008-02-11 15:57:55

Drivers like eHEA need memory notifiers in order to 
update their internal DMA memory map when memory is added
to or removed from the system.

Signed-off-by: Jan-Bernd Themann <redacted>


---
 Hi,

 this is the modified version with EXPORT_SYMBOL_GPL

 Regards,
 Jan-Bernd


 drivers/base/memory.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/base/memory.c b/drivers/base/memory.c
index 7ae413f..f5a0bf1 100644
--- a/drivers/base/memory.c
+++ b/drivers/base/memory.c
@@ -52,11 +52,13 @@ int register_memory_notifier(struct notifier_block *nb)
 {
         return blocking_notifier_chain_register(&memory_chain, nb);
 }
+EXPORT_SYMBOL_GPL(register_memory_notifier);
 
 void unregister_memory_notifier(struct notifier_block *nb)
 {
         blocking_notifier_chain_unregister(&memory_chain, nb);
 }
+EXPORT_SYMBOL_GPL(unregister_memory_notifier);
 
 /*
  * register_memory - Setup a sysfs device for a memory block
-- 
1.5.2

Re: [PATCH] drivers/base: export gpl (un)register_memory_notifier

From: Sam Ravnborg <hidden>
Date: 2008-02-11 16:02:20

On Mon, Feb 11, 2008 at 04:57:06PM +0100, Jan-Bernd Themann wrote:
Drivers like eHEA need memory notifiers in order to 
update their internal DMA memory map when memory is added
to or removed from the system.
Can you please add proper kernel-doc formatted comments
when you export a symbol so others can get a clue
what the exported function is supposed to do.

	Sam

Re: [PATCH] drivers/base: export gpl (un)register_memory_notifier

From: Dave Hansen <hidden>
Date: 2008-02-11 16:04:55

On Mon, 2008-02-11 at 16:57 +0100, Jan-Bernd Themann wrote:
Drivers like eHEA need memory notifiers in order to 
update their internal DMA memory map when memory is added
to or removed from the system.
Could you post this with the new users as well so we can make sure
they're not abusing this in some way?

-- Dave
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help