[PATCH] Fix ext4 bitops

Subsystems: the rest

STALE6756d

3 messages, 3 authors, 2008-02-04 · open the first message on its own page

[PATCH] Fix ext4 bitops

From: Bastian Blank <hidden>
Date: 2008-02-01 20:29:59

Fix ext4 bitops.

Signed-off-by: Bastian Blank <redacted>
diff --git a/include/asm-powerpc/bitops.h b/include/asm-powerpc/bitops.h
index 220d9a7..d0980df 100644
--- a/include/asm-powerpc/bitops.h
+++ b/include/asm-powerpc/bitops.h
@@ -363,6 +363,8 @@ unsigned long generic_find_next_le_bit(const unsigned long *addr,
 				    unsigned long size, unsigned long offset);
 /* Bitmap functions for the ext2 filesystem */
 
+#include <asm-generic/bitops/le.h>
+
 #define ext2_set_bit(nr,addr) \
 	__test_and_set_le_bit((nr), (unsigned long*)addr)
 #define ext2_clear_bit(nr, addr) \

Re: [PATCH] Fix ext4 bitops

From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: 2008-02-03 07:57:25

On Fri, 2008-02-01 at 21:02 +0100, Bastian Blank wrote:
Fix ext4 bitops.
Please provide a better description, as it's not obvious at first sight.
quoted hunk
Signed-off-by: Bastian Blank <redacted>
diff --git a/include/asm-powerpc/bitops.h b/include/asm-powerpc/bitops.h
index 220d9a7..d0980df 100644
--- a/include/asm-powerpc/bitops.h
+++ b/include/asm-powerpc/bitops.h
@@ -363,6 +363,8 @@ unsigned long generic_find_next_le_bit(const unsigned long *addr,
 				    unsigned long size, unsigned long offset);
 /* Bitmap functions for the ext2 filesystem */
 
+#include <asm-generic/bitops/le.h>
A comment would be useful to indicate that this defines the _le versions
of the bitops as it would be easy to mistake that for something else.
 #define ext2_set_bit(nr,addr) \
 	__test_and_set_le_bit((nr), (unsigned long*)addr)
 #define ext2_clear_bit(nr, addr) \
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH] Fix ext4 bitops

From: Aneesh Kumar K.V <hidden>
Date: 2008-02-04 05:23:20

On Fri, Feb 01, 2008 at 09:02:40PM +0100, Bastian Blank wrote:
quoted hunk
Fix ext4 bitops.

Signed-off-by: Bastian Blank <redacted>
diff --git a/include/asm-powerpc/bitops.h b/include/asm-powerpc/bitops.h
index 220d9a7..d0980df 100644
--- a/include/asm-powerpc/bitops.h
+++ b/include/asm-powerpc/bitops.h
@@ -363,6 +363,8 @@ unsigned long generic_find_next_le_bit(const unsigned long *addr,
 				    unsigned long size, unsigned long offset);
 /* Bitmap functions for the ext2 filesystem */

+#include <asm-generic/bitops/le.h>
+
 #define ext2_set_bit(nr,addr) \
 	__test_and_set_le_bit((nr), (unsigned long*)addr)
 #define ext2_clear_bit(nr, addr) \

I am not sure what the changes are for. Can you send me the build logs
with the compile error. I always test Ext4 on powerpc so not sure what
went wrong.

-aneesh
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help