[PATCH] PMU: don't lock_kernel()
From: Johannes Berg <johannes@sipsolutions.net>
Date: 2007-11-14 12:42:40
I see nothing that this lock_kernel() actually protects against so remove it. Signed-off-by: Johannes Berg <johannes@sipsolutions.net> Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org> --- Please queue to whatever branch you feel appropriate. drivers/macintosh/via-pmu.c | 3 --- 1 file changed, 3 deletions(-)
--- everything.orig/drivers/macintosh/via-pmu.c 2007-11-13 19:32:01.728726509 +0100
+++ everything/drivers/macintosh/via-pmu.c 2007-11-13 19:32:03.058713543 +0100@@ -33,7 +33,6 @@ #include <linux/adb.h> #include <linux/pmu.h> #include <linux/cuda.h> -#include <linux/smp_lock.h> #include <linux/module.h> #include <linux/spinlock.h> #include <linux/pm.h>
@@ -2547,7 +2546,6 @@ pmu_release(struct inode *inode, struct struct pmu_private *pp = file->private_data; unsigned long flags; - lock_kernel(); if (pp != 0) { file->private_data = NULL; spin_lock_irqsave(&all_pvt_lock, flags);
@@ -2561,7 +2559,6 @@ pmu_release(struct inode *inode, struct kfree(pp); } - unlock_kernel(); return 0; }