From: Steven A. Falco <hidden> Date: 2007-10-30 21:24:03
Hi - I have found a bug in the ARCH=powerpc Walnut BSP. The order of
the ethernet interrupts in the walnut.dts file doesn't match the
documentation. I discovered this when porting the BSP to a custom board
- the ethernet would not work. The attached patch corrects that.
This is the first patch I am submitting, so please advise me if there is
anything I should do differently.
Signed-off-by: Steve Falco <sfalco at harris.com>
From: Steven A. Falco <hidden> Date: 2007-10-30 21:41:30
I realized that I should have done this from the root level. So here is
the corrected patch.
Signed-off-by: Steve Falco <sfalco at harris.com>
Steven A. Falco wrote:
Hi - I have found a bug in the ARCH=powerpc Walnut BSP. The order of
the ethernet interrupts in the walnut.dts file doesn't match the
documentation. I discovered this when porting the BSP to a custom
board - the ethernet would not work. The attached patch corrects that.
This is the first patch I am submitting, so please advise me if there
is anything I should do differently.
Signed-off-by: Steve Falco <sfalco at harris.com>
On Tue, 30 Oct 2007 17:41:27 -0400
"Steven A. Falco" [off-list ref] wrote:
quoted hunk
From: "Steven A. Falco" <redacted>
To: linuxppc-dev@ozlabs.org
Subject: Re: PPC405GP Walnut irq patch
Date: Tue, 30 Oct 2007 17:41:27 -0400
Sender: linuxppc-dev-bounces+jwboyer=gmail.com@ozlabs.org
User-Agent: Thunderbird 2.0.0.5 (X11/20070719)
I realized that I should have done this from the root level. So here is
the corrected patch.
Signed-off-by: Steve Falco <sfalco at harris.com>
Steven A. Falco wrote:
quoted
Hi - I have found a bug in the ARCH=powerpc Walnut BSP. The order of
the ethernet interrupts in the walnut.dts file doesn't match the
documentation. I discovered this when porting the BSP to a custom
board - the ethernet would not work. The attached patch corrects that.
This is the first patch I am submitting, so please advise me if there
is anything I should do differently.
Signed-off-by: Steve Falco <sfalco at harris.com>
From: Steven A. Falco <hidden> Date: 2007-10-31 17:52:57
Could you redo the patch with just this bit and send it again?
josh
Ok - this one is based off the Linus tree, and follows your style of one
interrupt per line, with a comment indicating which one it is.
Signed-off-by: Steve Falco <sfalco at harris.com>
@@ -122,7 +122,9 @@device_type="network";compatible="ibm,emac-405gp","ibm,emac";interrupt-parent=<&UIC0>;-interrupts=<94f4>;+interrupts=<+f4/* Ethernet */+94/* Ethernet Wake Up */>;local-mac-address=[000000000000];/* Filled in by zImage */reg=<ef60080070>;mal-device=<&MAL>;