[PATCH v2] [POWERPC] ucc_geth: Fix build break introduced by commit 09f75cd7bf13720738e6a196cc0107ce9a5bd5a0

Subsystems: networking drivers, the rest

STALE6903d

3 messages, 3 authors, 2007-10-15 · open the first message on its own page

[PATCH v2] [POWERPC] ucc_geth: Fix build break introduced by commit 09f75cd7bf13720738e6a196cc0107ce9a5bd5a0

From: Emil Medve <hidden>
Date: 2007-10-15 13:51:37

drivers/net/ucc_geth.c: In function 'ucc_geth_rx':
drivers/net/ucc_geth.c:3483: error: 'dev' undeclared (first use in this function)
drivers/net/ucc_geth.c:3483: error: (Each undeclared identifier is reported only once
drivers/net/ucc_geth.c:3483: error: for each function it appears in.)
make[2]: *** [drivers/net/ucc_geth.o] Error 1

Signed-off-by: Emil Medve <redacted>
---

Here is a convenient link for the culprit patch: http://git.kernel.org/?p=linux/kernel/git/jgarzik/netdev-2.6.git;a=commit;h=09f75cd7bf13720738e6a196cc0107ce9a5bd5a0

netdev-2.6> scripts/checkpatch.pl 0001-POWERPC-ucc_geth-Fix-build-break-introduced-by-co.patch 
Your patch has no obvious style problems and is ready for submission.

 drivers/net/ucc_geth.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ucc_geth.c b/drivers/net/ucc_geth.c
index d00e7d4..bec413b 100644
--- a/drivers/net/ucc_geth.c
+++ b/drivers/net/ucc_geth.c
@@ -63,7 +63,7 @@
 #define UGETH_MSG_DEFAULT	(NETIF_MSG_IFUP << 1 ) - 1
 
 void uec_set_ethtool_ops(struct net_device *netdev);
-	
+
 static DEFINE_SPINLOCK(ugeth_lock);
 
 static struct {
@@ -3454,9 +3454,12 @@ static int ucc_geth_rx(struct ucc_geth_private *ugeth, u8 rxQ, int rx_work_limit
 	u16 length, howmany = 0;
 	u32 bd_status;
 	u8 *bdBuffer;
+	struct net_device * dev;
 
 	ugeth_vdbg("%s: IN", __FUNCTION__);
 
+	dev = ugeth->dev;
+
 	/* collect received buffers */
 	bd = ugeth->rxBd[rxQ];
 
-- 
1.5.3.GIT

RE: [PATCH v2] [POWERPC] ucc_geth: Fix build break introduced by commit 09f75cd7bf13720738e6a196cc0107ce9a5bd5a0

From: Li Yang-r58472 <hidden>
Date: 2007-10-15 14:11:10

-----Original Message-----
From: Medve Emilian-EMMEDVE1=20
Sent: Monday, October 15, 2007 9:44 PM
To: akpm@linux-foundation.org; jgarzik@pobox.com; Li=20
Yang-r58472; netdev@vger.kernel.org; linuxppc-dev@ozlabs.org
Cc: Medve Emilian-EMMEDVE1
Subject: [PATCH v2] [POWERPC] ucc_geth: Fix build break=20
introduced by commit 09f75cd7bf13720738e6a196cc0107ce9a5bd5a0
=20
drivers/net/ucc_geth.c: In function 'ucc_geth_rx':
drivers/net/ucc_geth.c:3483: error: 'dev' undeclared (first=20
use in this function)
drivers/net/ucc_geth.c:3483: error: (Each undeclared=20
identifier is reported only once
drivers/net/ucc_geth.c:3483: error: for each function it appears in.)
make[2]: *** [drivers/net/ucc_geth.o] Error 1
=20
Signed-off-by: Emil Medve <redacted>
Acked-by: Li Yang <redacted>
quoted hunk
---
=20
Here is a convenient link for the culprit patch:=20
http://git.kernel.org/?p=3Dlinux/kernel/git/jgarzik/netdev-2.6.g
it;a=3Dcommit;h=3D09f75cd7bf13720738e6a196cc0107ce9a5bd5a0
=20
netdev-2.6> scripts/checkpatch.pl=20
0001-POWERPC-ucc_geth-Fix-build-break-introduced-by-co.patch
Your patch has no obvious style problems and is ready for submission.
=20
 drivers/net/ucc_geth.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)
=20
diff --git a/drivers/net/ucc_geth.c b/drivers/net/ucc_geth.c=20
index d00e7d4..bec413b 100644
--- a/drivers/net/ucc_geth.c
+++ b/drivers/net/ucc_geth.c
@@ -63,7 +63,7 @@
 #define UGETH_MSG_DEFAULT	(NETIF_MSG_IFUP << 1 ) - 1
=20
 void uec_set_ethtool_ops(struct net_device *netdev);
-=09
+
 static DEFINE_SPINLOCK(ugeth_lock);
=20
 static struct {
@@ -3454,9 +3454,12 @@ static int ucc_geth_rx(struct=20
ucc_geth_private *ugeth, u8 rxQ, int rx_work_limit
 	u16 length, howmany =3D 0;
 	u32 bd_status;
 	u8 *bdBuffer;
+	struct net_device * dev;
=20
 	ugeth_vdbg("%s: IN", __FUNCTION__);
=20
+	dev =3D ugeth->dev;
+
 	/* collect received buffers */
 	bd =3D ugeth->rxBd[rxQ];
=20
--
1.5.3.GIT
=20

Re: [PATCH v2] [POWERPC] ucc_geth: Fix build break introduced by commit 09f75cd7bf13720738e6a196cc0107ce9a5bd5a0

From: Jeff Garzik <hidden>
Date: 2007-10-15 18:51:59

Emil Medve wrote:
drivers/net/ucc_geth.c: In function 'ucc_geth_rx':
drivers/net/ucc_geth.c:3483: error: 'dev' undeclared (first use in this function)
drivers/net/ucc_geth.c:3483: error: (Each undeclared identifier is reported only once
drivers/net/ucc_geth.c:3483: error: for each function it appears in.)
make[2]: *** [drivers/net/ucc_geth.o] Error 1

Signed-off-by: Emil Medve <redacted>
---

Here is a convenient link for the culprit patch: http://git.kernel.org/?p=linux/kernel/git/jgarzik/netdev-2.6.git;a=commit;h=09f75cd7bf13720738e6a196cc0107ce9a5bd5a0

netdev-2.6> scripts/checkpatch.pl 0001-POWERPC-ucc_geth-Fix-build-break-introduced-by-co.patch 
Your patch has no obvious style problems and is ready for submission.
applied
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help