Re: [POWERPC 03/15] [POWERPC] TQM5200 board support

In message [off-list ref] you wrote:

quoted

quoted

Why don't we fix it in U-Boot, then, and get rid of this in Linux?

Mostly because I haven't gotten to it yet.  :-/

Actually, it's more than that.  I don't want to force users to upgrade
their firmware on the lite5200.  Linux boots on it fine now with old
firmware (using cuimage), it should continue to boot.  Doing board
specific fixups at Linux setup_arch time to work around
old/buggy/not-quite-what-we-want firmware is reasonable.  We must do
this on the Efika too.

Maybe there's a way to allow booting with old firmware, but
nevertheless providing a technically clean, up to date version of
U-Boot for current kernels?

My point is that the Lite5200B is a reference design  -  many  people
copy the hardware design and use the code as starting point for their
own  board adaptions. So this port has to be as clean as possible, or
we will see the same remarks in nearly every new 5200 patch to come.

Please, let's clean this up.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
I'm a programmer: I don't buy software, I write it.
                                                  -- Tom Christiansen

On 10/8/07, Wolfgang Denk [off-list ref] wrote:

In message [off-list ref] you wrote:

quoted

quoted

quoted

Why don't we fix it in U-Boot, then, and get rid of this in Linux?

Mostly because I haven't gotten to it yet.  :-/

Actually, it's more than that.  I don't want to force users to upgrade
their firmware on the lite5200.  Linux boots on it fine now with old
firmware (using cuimage), it should continue to boot.  Doing board
specific fixups at Linux setup_arch time to work around
old/buggy/not-quite-what-we-want firmware is reasonable.  We must do
this on the Efika too.

Maybe there's a way to allow booting with old firmware, but
nevertheless providing a technically clean, up to date version of
U-Boot for current kernels?

My point is that the Lite5200B is a reference design  -  many  people
copy the hardware design and use the code as starting point for their
own  board adaptions. So this port has to be as clean as possible, or
we will see the same remarks in nearly every new 5200 patch to come.

Please, let's clean this up.

Yes, I agree.  I need to think about this a bit.  In the mean time,
I've submitted a lite5200 patch that makes it clear the CPU setup
fixups are *not* common code and should *not* be duplicated.  :-)

Cheers,
g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
grant.likely@secretlab.ca
(403) 399-0195