[PATCH] compat_ioctl: fix block device compat ioctl regression

STALE6900d

2 messages, 2 authors, 2007-10-27 · open the first message on its own page

[PATCH] compat_ioctl: fix block device compat ioctl regression

From: Arnd Bergmann <arnd@arndb.de>
Date: 2007-10-27 09:39:25

From: Philip Langdale <redacted>
The conversion of handlers to compat_blkdev_ioctl accidentally
disabled handling of most ioctl numbers on block devices because
of a typo. Fix the one line to enable it all again.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---

Mea Culpa. This should have been found by my testing, as it's clear
that most of my big patch never worked at all. Sorry for causing
problems for everyone involved here.

I'm attributing the patch to Philip, as he's the one who pointed
out to me what the fix is.

	Arnd <><
--- a/block/compat_ioctl.c
+++ b/block/compat_ioctl.c
@@ -581,7 +581,7 @@ static int compat_blkdev_driver_ioctl(struct inode *inode, struct file *file,
 {
 	int ret;
 
-	switch (arg) {
+	switch (cmd) {
 	case HDIO_GET_UNMASKINTR:
 	case HDIO_GET_MULTCOUNT:
 	case HDIO_GET_KEEPSETTINGS:

Re: [PATCH] compat_ioctl: fix block device compat ioctl regression

From: Jens Axboe <hidden>
Date: 2007-10-27 11:34:48

On Sat, Oct 27 2007, Arnd Bergmann wrote:
From: Philip Langdale <redacted>
The conversion of handlers to compat_blkdev_ioctl accidentally
disabled handling of most ioctl numbers on block devices because
of a typo. Fix the one line to enable it all again.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---

Mea Culpa. This should have been found by my testing, as it's clear
that most of my big patch never worked at all. Sorry for causing
problems for everyone involved here.

I'm attributing the patch to Philip, as he's the one who pointed
out to me what the fix is.
Oops, added for swift inclusion.

-- 
Jens Axboe
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help