[PATCH] ppc32/8xx: Fix r3 trashing due to 8MB TLB page instantiation

STALE6913d

4 messages, 3 authors, 2007-08-30 · open the first message on its own page

[PATCH] ppc32/8xx: Fix r3 trashing due to 8MB TLB page instantiation

From: Jochen Friedrich <jochen@scram.de>
Date: 2007-08-28 11:43:53 

Instantiation of 8MB pages on the TLB cache for the kernel static
mapping trashes r3 register on !CONFIG_8xx_CPU6 configurations.
This ensures r3 gets saved and restored.

This has been posted to linuxppc-embedded by Marcelo Tosatti
[off-list ref], but only an incomplete version of the patch
has been applied in c51e078f82096a7d35ac8ec2416272e843a0e1c4.
This patch adds the rest of the fix.

Signed-off-by: Jochen Friedrich <jochen@scram.de>
---
 arch/ppc/kernel/head_8xx.S |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

This can be pulled from git://git.bocc.de/dbox2.git ppc-fixes

Re: [PATCH] ppc32/8xx: Fix r3 trashing due to 8MB TLB page instantiation

From: Marcelo Tosatti <hidden>
Date: 2007-08-29 13:05:34 

Please apply. 

On Tue, Aug 28, 2007 at 01:20:48PM +0200, Jochen Friedrich wrote:
Instantiation of 8MB pages on the TLB cache for the kernel static
mapping trashes r3 register on !CONFIG_8xx_CPU6 configurations.
This ensures r3 gets saved and restored.

This has been posted to linuxppc-embedded by Marcelo Tosatti
[off-list ref], but only an incomplete version of the patch
has been applied in c51e078f82096a7d35ac8ec2416272e843a0e1c4.
This patch adds the rest of the fix.

Signed-off-by: Jochen Friedrich <jochen@scram.de>
---
 arch/ppc/kernel/head_8xx.S |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

This can be pulled from git://git.bocc.de/dbox2.git ppc-fixes

Re: [PATCH] ppc32/8xx: Fix r3 trashing due to 8MB TLB page instantiation

From: Kumar Gala <hidden>
Date: 2007-08-29 23:05:53 

On Aug 28, 2007, at 6:20 AM, Jochen Friedrich wrote:
quoted hunk
Instantiation of 8MB pages on the TLB cache for the kernel static
mapping trashes r3 register on !CONFIG_8xx_CPU6 configurations.
This ensures r3 gets saved and restored.

This has been posted to linuxppc-embedded by Marcelo Tosatti
[off-list ref], but only an incomplete version of the patch
has been applied in c51e078f82096a7d35ac8ec2416272e843a0e1c4.
This patch adds the rest of the fix.

Signed-off-by: Jochen Friedrich <jochen@scram.de>
---
 arch/ppc/kernel/head_8xx.S |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

This can be pulled from git://git.bocc.de/dbox2.git ppc-fixes
diff --git a/arch/ppc/kernel/head_8xx.S b/arch/ppc/kernel/head_8xx.S
index 944c35c..eb8d26f 100644
--- a/arch/ppc/kernel/head_8xx.S
+++ b/arch/ppc/kernel/head_8xx.S
@@ -495,9 +495,7 @@ LoadLargeDTLB:
 	lwz	r11, 4(r0)

 	lwz	r12, 16(r0)
-#ifdef CONFIG_8xx_CPU6
 	lwz	r3, 8(r0)
-#endif
 	rfi

 /* This is the data TLB error on the MPC8xx.  This could be due to
do we need this in arch/powerpc as well?

- k

Re: [PATCH] ppc32/8xx: Fix r3 trashing due to 8MB TLB page instantiation

From: Jochen Friedrich <jochen@scram.de>
Date: 2007-08-30 08:49:06 

Hi Kumar,

do we need this in arch/powerpc as well?
No. At least not until these patches are applied to powerpc, as well:

8f069b1a90bd97bf6d59a02ecabf0173d9175609 [PATCH] powerpc/8xx: Use 8MB D-TLB's for kernel static mapping faults
3ea4807de7b2c5c903380ba2c2e7150bee942f42 [PATCH] powerpc/8xx: last two 8MB D-TLB entries are incorrectly set
c51e078f82096a7d35ac8ec2416272e843a0e1c4 [PATCH] ppc32/8xx: Fix r3 trashing due to 8MB TLB page instantiation

Thanks,
Jochen
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help