[PATCH] fix compile warning in arch/powerpc/kernel/sysfs.c

STALE6940d

2 messages, 1 author, 2007-08-17 · open the first message on its own page

[PATCH] fix compile warning in arch/powerpc/kernel/sysfs.c

From: Michael Neuling <hidden>
Date: 2007-08-17 03:40:13

This fixes the following warning:
arch/powerpc/kernel/sysfs.c:388: warning: ignoring return value of
'sysfs_create_group', declared with attribute warn_unused_result

Signed-off-by: Michael Neuling <redacted>
---
 arch/powerpc/kernel/sysfs.c |    8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

Index: linux-2.6-ozlabs/arch/powerpc/kernel/sysfs.c
===================================================================
--- linux-2.6-ozlabs.orig/arch/powerpc/kernel/sysfs.c
+++ linux-2.6-ozlabs/arch/powerpc/kernel/sysfs.c
@@ -378,14 +378,18 @@ EXPORT_SYMBOL_GPL(cpu_add_sysdev_attr);
 
 int cpu_add_sysdev_attr_group(struct attribute_group *attrs)
 {
-	int cpu;
+	int cpu, err;
 	struct sys_device *sysdev;
 
 	mutex_lock(&cpu_mutex);
 
 	for_each_possible_cpu(cpu) {
 		sysdev = get_cpu_sysdev(cpu);
-		sysfs_create_group(&sysdev->kobj, attrs);
+		err = sysfs_create_group(&sysdev->kobj, attrs);
+		if (err) {
+			mutex_unlock(&cpu_mutex);
+			return err;
+		}
 	}
 
 	mutex_unlock(&cpu_mutex);

Re: [PATCH] fix compile warning in arch/powerpc/kernel/sysfs.c

From: Michael Neuling <hidden>
Date: 2007-08-17 05:25:58

It seems I missed a long discussion about this warning... Please ignore.

Mikey

In message [off-list ref] you wrote:
quoted hunk
This fixes the following warning:
arch/powerpc/kernel/sysfs.c:388: warning: ignoring return value of
'sysfs_create_group', declared with attribute warn_unused_result

Signed-off-by: Michael Neuling <redacted>
---
 arch/powerpc/kernel/sysfs.c |    8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

Index: linux-2.6-ozlabs/arch/powerpc/kernel/sysfs.c
===================================================================
--- linux-2.6-ozlabs.orig/arch/powerpc/kernel/sysfs.c
+++ linux-2.6-ozlabs/arch/powerpc/kernel/sysfs.c
@@ -378,14 +378,18 @@ EXPORT_SYMBOL_GPL(cpu_add_sysdev_attr);
 
 int cpu_add_sysdev_attr_group(struct attribute_group *attrs)
 {
-	int cpu;
+	int cpu, err;
 	struct sys_device *sysdev;
 
 	mutex_lock(&cpu_mutex);
 
 	for_each_possible_cpu(cpu) {
 		sysdev = get_cpu_sysdev(cpu);
-		sysfs_create_group(&sysdev->kobj, attrs);
+		err = sysfs_create_group(&sysdev->kobj, attrs);
+		if (err) {
+			mutex_unlock(&cpu_mutex);
+			return err;
+		}
 	}
 
 	mutex_unlock(&cpu_mutex);

_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help