[PATCH] ps3: Fix no storage devices found

STALE6932d

2 messages, 2 authors, 2007-08-14 · open the first message on its own page

[PATCH] ps3: Fix no storage devices found

From: Geert Uytterhoeven <hidden>
Date: 2007-08-14 16:30:16

Fix probing of PS3 storage devices: in the success case, we should set `error'
to zero, not `result'.

Without this patch no storage devices are found.

Signed-off-by: Geert Uytterhoeven <redacted>
---
This brown paper bag bug slipped in due to bad patch splitting.
Please apply as soon as possible. Thanks!

 arch/powerpc/platforms/ps3/device-init.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)
--- a/arch/powerpc/platforms/ps3/device-init.c
+++ b/arch/powerpc/platforms/ps3/device-init.c
@@ -372,7 +372,7 @@ static int ps3_storage_wait_for_device(c
 		    notify_event->dev_type == repo->dev_type) {
 			pr_debug("%s:%u: device ready: dev_id %u\n", __func__,
 				 __LINE__, repo->dev_id);
-			result = 0;
+			error = 0;
 			break;
 		}
 
With kind regards,
 
Geert Uytterhoeven
Software Architect

Sony Network and Software Technology Center Europe
The Corporate Village · Da Vincilaan 7-D1 · B-1935 Zaventem · Belgium
 
Phone:    +32 (0)2 700 8453	
Fax:      +32 (0)2 700 8622	
E-mail:   Geert.Uytterhoeven@sonycom.com	
Internet: http://www.sony-europe.com/
 	
Sony Network and Software Technology Center Europe	
A division of Sony Service Centre (Europe) N.V.	
Registered office: Technologielaan 7 · B-1840 Londerzeel · Belgium	
VAT BE 0413.825.160 · RPR Brussels	
Fortis Bank Zaventem · Swift GEBABEBB08A · IBAN BE39001382358619

Re: [PATCH] ps3: Fix no storage devices found

From: Geoff Levand <hidden>
Date: 2007-08-14 16:40:14

Geert Uytterhoeven wrote:
Fix probing of PS3 storage devices: in the success case, we should set `error'
to zero, not `result'.

Without this patch no storage devices are found.

Signed-off-by: Geert Uytterhoeven <redacted>
---
This brown paper bag bug slipped in due to bad patch splitting.
Please apply as soon as possible. Thanks!
Looks good.

Acked-by: Geoff Levand <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help