Re: [patch 1/3] ps3: Disk Storage Driver

Jeff Garzik [off-list ref] writes:

Andy Whitcroft wrote:

quoted

Andrew Morton wrote:

quoted

quoted

+	start_sector = req->sector*priv->blocking_factor;
+	sectors = req->nr_sectors*priv->blocking_factor;

s/*/ * /.  checkpatch missed this.

Ok, this is something we need to decide on.  Currently we only ask for
consistent spacing on all the mathematic operators.  This is mostly as
we do see a large number of non-spaced uses in defines and the like.

I am happy to expand these tests so they are always spaced on both sides
style if that is the preference.

That is most definitely the preference:  spaces surround operators.

                                                          ^binary

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Andreas Schwab wrote:

Jeff Garzik [off-list ref] writes:

quoted

Andy Whitcroft wrote:

quoted

Andrew Morton wrote:

quoted

quoted

+	start_sector = req->sector*priv->blocking_factor;
+	sectors = req->nr_sectors*priv->blocking_factor;

s/*/ * /.  checkpatch missed this.

Ok, this is something we need to decide on.  Currently we only ask for
consistent spacing on all the mathematic operators.  This is mostly as
we do see a large number of non-spaced uses in defines and the like.

I am happy to expand these tests so they are always spaced on both sides
style if that is the preference.

That is most definitely the preference:  spaces surround operators.

                                                          ^binary

Yes.  :)

	Jeff