Re: [PATCH 04/10] IB/ehca: use common error code mapping instead of specific ones

2 messages, 2 authors, 2007-07-16 · open the first message on its own page

Re: [PATCH 04/10] IB/ehca: use common error code mapping instead of specific ones

From: Roland Dreier <hidden>
Date: 2007-07-16 17:14:21

 > @@ -161,8 +161,11 @@ static inline int ehca2ib_return_code(u64 ehca_rc)

applied, but as a further cleanup it seems that ehca2ib_return_code()
should be moved into a .c file and moved out of line -- I think it
would probably shrink the compiled code quite a bit, and as far as I
can see it is never used in the data path where the function call
overhead would matter at all.

Re: [PATCH 04/10] IB/ehca: use common error code mapping instead of specific ones

From: Joachim Fenkes <hidden>
Date: 2007-07-16 20:36:24

Roland Dreier [off-list ref] wrote on 16.07.2007 19:14:03:
applied, but as a further cleanup it seems that ehca2ib_return_code()
should be moved into a .c file and moved out of line -- I think it
would probably shrink the compiled code quite a bit, and as far as I
can see it is never used in the data path where the function call
overhead would matter at all.
Sounds reasonable; I'll put it in the next patch series.

Joachim
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help