From: Andy Fleming <hidden> Date: 2007-07-18 06:36:04
phy_read() returns a negative number if there's an error, but the
error-checking code in the Vitesse driver's config_intr function
triggers if phy_read() returns non-zero. Correct that.
Signed-off-by: Andy Fleming <redacted>
---
I made a really stupid mistake in the 4 patches I sent out, earlier. I
thought those patches had been tested, but they hadn't been. This one
corrects a tiny error in the patch, and they have now been tested. As before
this change can be pulled from:
http://opensource.freescale.com/pub/scm/linux-2.6-85xx.git netdev
Really, REALLY sorry about that. I have been given a paper bag of appropriate
size and shape to fit over my head.
drivers/net/phy/vitesse.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
phy_read() returns a negative number if there's an error, but the
error-checking code in the Vitesse driver's config_intr function
triggers if phy_read() returns non-zero. Correct that.
Signed-off-by: Andy Fleming <redacted>
---
I made a really stupid mistake in the 4 patches I sent out, earlier. I
thought those patches had been tested, but they hadn't been. This one
corrects a tiny error in the patch, and they have now been tested. As before
this change can be pulled from:
http://opensource.freescale.com/pub/scm/linux-2.6-85xx.git netdev
Really, REALLY sorry about that. I have been given a paper bag of appropriate
size and shape to fit over my head.
drivers/net/phy/vitesse.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
@@ -109,7 +109,7 @@ static int vsc824x_config_intr(struct phy_device *phydev)*/err=phy_read(phydev,MII_VSC8244_ISTAT);-if(err)+if(err<0)returnerr;
but would that mean, if phy_read returns > 0 it is a success?
thanks
err = phy_write(phydev, MII_VSC8244_IMASK, 0);
--
1.5.0.2.230.gfbe3d-dirty
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Andy Fleming <hidden> Date: 2007-07-18 18:52:57
On Jul 18, 2007, at 02:00, pradeep singh wrote:
On 7/18/07, Andy Fleming [off-list ref] wrote:
quoted
- if (err)
+ if (err < 0)
return err;
but would that mean, if phy_read returns > 0 it is a success?
Yes. phy_read() returns a 32-bit value. If there's an error, it
returns a negative number. If not, it returns whatever was in the
register (which is only 16 bits)
phy_write() returns 0 on success, and non-zero, otherwise. In
hindsight, it would have been better to be consistent.
Andy
From: Jon Loeliger <hidden> Date: 2007-07-19 16:49:49
On Wed, 2007-07-18 at 01:35, Andy Fleming wrote:
quoted hunk
phy_read() returns a negative number if there's an error, but the
error-checking code in the Vitesse driver's config_intr function
triggers if phy_read() returns non-zero. Correct that.
Signed-off-by: Andy Fleming <redacted>
---
I made a really stupid mistake in the 4 patches I sent out, earlier. I
thought those patches had been tested, but they hadn't been. This one
corrects a tiny error in the patch, and they have now been tested. As before
this change can be pulled from:
http://opensource.freescale.com/pub/scm/linux-2.6-85xx.git netdev
Really, REALLY sorry about that. I have been given a paper bag of appropriate
size and shape to fit over my head.
drivers/net/phy/vitesse.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
From: Kumar Gala <hidden> Date: 2007-07-19 19:56:52
On Jul 18, 2007, at 1:35 AM, Andy Fleming wrote:
phy_read() returns a negative number if there's an error, but the
error-checking code in the Vitesse driver's config_intr function
triggers if phy_read() returns non-zero. Correct that.
Signed-off-by: Andy Fleming <redacted>
Jeff,
Can you make sure to send this to linus since its need to properly
fix the Vitesse phy's used on the 8641HPCN and 8544 DS boards.
thanks
- k
quoted hunk
---
I made a really stupid mistake in the 4 patches I sent out,
earlier. I
thought those patches had been tested, but they hadn't been. This one
corrects a tiny error in the patch, and they have now been tested.
As before
this change can be pulled from:
http://opensource.freescale.com/pub/scm/linux-2.6-85xx.git netdev
Really, REALLY sorry about that. I have been given a paper bag of
appropriate
size and shape to fit over my head.
drivers/net/phy/vitesse.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
@@ -109,7 +109,7 @@ static int vsc824x_config_intr(struct
phy_device *phydev)
*/
err = phy_read(phydev, MII_VSC8244_ISTAT);
- if (err)
+ if (err < 0)
return err;
err = phy_write(phydev, MII_VSC8244_IMASK, 0);
--
1.5.0.2.230.gfbe3d-dirty
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html