19 messages, 7 authors, 2007-07-16 · open the first message on its own page
From: Matt Sealey <hidden>
Date: 2007-07-11 18:05:29
Does anyone have the definitive patchset to enable the tickless hz, some kind of hrtimer and the other related improvements in the PowerPC tree? -- Matt Sealey [off-list ref] Genesi, Manager, Developer Relations
From: Sergei Shtylyov <hidden>
Date: 2007-07-11 18:15:55
Hello. Matt Sealey wrote:
Does anyone have the definitive patchset to enable the tickless hz, some kind of hrtimer and the other related improvements in the PowerPC tree?
Look into the -rt patch which has the all this (minus TOD vsyscalls).
MBR, Sergei
From: Michael Neuling <hidden>
Date: 2007-07-11 18:33:05
Does anyone have the definitive patchset to enable the tickless hz, some kind of hrtimer and the other related improvements in the PowerPC tree?
Tony Breeds has been looking at this. I think he wanted to clean his patch set up before he posted it. Mikey
From: Matt Sealey <hidden>
Date: 2007-07-11 22:14:28
Okay. What I didn't want to do is spend a day sifting some other development tree picking out what I think might be possibly sort of the right patches for it. I'd get it wrong because having not worked on it, I don't know what I am even looking for. And I don't want to run -rt or wireless-dev for the benefit of a single feature. What I am after is something like Ingo Molnar throws out.. single patches done the old way, not git trees. It's so much easier to handle and integrate for example into a Gentoo ebuild or to make a tarball of accumulated patches from a certain release kernel. -- Matt Sealey [off-list ref] Genesi, Manager, Developer Relations Michael Neuling wrote:
quoted
Does anyone have the definitive patchset to enable the tickless hz, some kind of hrtimer and the other related improvements in the PowerPC tree?Tony Breeds has been looking at this. I think he wanted to clean his patch set up before he posted it. Mikey
From: Tony Breeds <hidden>
Date: 2007-07-12 06:41:16
On Wed, Jul 11, 2007 at 11:15:16PM +0100, Matt Sealey wrote:
And I don't want to run -rt or wireless-dev for the benefit of a single feature. What I am after is something like Ingo Molnar throws out.. single patches done the old way, not git trees. It's so much easier to handle and integrate for example into a Gentoo ebuild or to make a tarball of accumulated patches from a certain release kernel.
Hi Matt, In the near future I will have something that I can pass around for review. Which will be a quilt series of about 5 patches (based on mainline). I'll make sure to include you in the reviewers list. At this stage I'd hope they'll be in 2.6.24. I have HRT in a state where you can enable it and it works, but NO_HZ isn't quite right yet. Yours Tony linux.conf.au http://linux.conf.au/ || http://lca2008.linux.org.au/ Jan 28 - Feb 02 2008 The Australian Linux Technical Conference!
From: Domen Puncer <hidden>
Date: 2007-07-12 06:51:08
On 11/07/07 19:06 +0100, Matt Sealey wrote:
Does anyone have the definitive patchset to enable the tickless hz, some kind of hrtimer and the other related improvements in the PowerPC tree?
I use attached patches for tickless. Order in which they're applied: PowerPC_GENERIC_CLOCKEVENTS.patch PowerPC_GENERIC_TIME.linux-2.6.18-rc6_timeofday-arch-ppc_C6.patch PowerPC_enable_HRT_and_dynticks_support.patch PowerPC_no_hz_fix.patch tickless-enable.patch HTH Domen
From: Matt Sealey <hidden>
Date: 2007-07-12 12:06:40
Hi Tony, What does "isn't quite right yet" mean? Broken, acts funny, or just a messy patch? -- Matt Sealey [off-list ref] Genesi, Manager, Developer Relations Tony Breeds wrote:
On Wed, Jul 11, 2007 at 11:15:16PM +0100, Matt Sealey wrote:quoted
And I don't want to run -rt or wireless-dev for the benefit of a single feature. What I am after is something like Ingo Molnar throws out.. single patches done the old way, not git trees. It's so much easier to handle and integrate for example into a Gentoo ebuild or to make a tarball of accumulated patches from a certain release kernel.Hi Matt, In the near future I will have something that I can pass around for review. Which will be a quilt series of about 5 patches (based on mainline). I'll make sure to include you in the reviewers list. At this stage I'd hope they'll be in 2.6.24. I have HRT in a state where you can enable it and it works, but NO_HZ isn't quite right yet. Yours Tony linux.conf.au http://linux.conf.au/ || http://lca2008.linux.org.au/ Jan 28 - Feb 02 2008 The Australian Linux Technical Conference!
From: Matt Sealey <hidden>
Date: 2007-07-12 12:07:06
Domen, You wouldn't have tried these on the Efika yet, would you? -- Matt Sealey [off-list ref] Genesi, Manager, Developer Relations Domen Puncer wrote:
On 11/07/07 19:06 +0100, Matt Sealey wrote:quoted
Does anyone have the definitive patchset to enable the tickless hz, some kind of hrtimer and the other related improvements in the PowerPC tree?I use attached patches for tickless. Order in which they're applied: PowerPC_GENERIC_CLOCKEVENTS.patch PowerPC_GENERIC_TIME.linux-2.6.18-rc6_timeofday-arch-ppc_C6.patch PowerPC_enable_HRT_and_dynticks_support.patch PowerPC_no_hz_fix.patch tickless-enable.patch HTH Domen
From: Sergei Shtylyov <hidden>
Date: 2007-07-12 14:09:43
Hello. Domen Puncer wrote:
quoted
Does anyone have the definitive patchset to enable the tickless hz, some kind of hrtimer and the other related improvements in the PowerPC tree?
I use attached patches for tickless. Order in which they're applied:
PowerPC_GENERIC_CLOCKEVENTS.patch
That's my patch which used to have both description and signoff that I'm
not seeing in the attached version...
PowerPC_GENERIC_TIME.linux-2.6.18-rc6_timeofday-arch-ppc_C6.patch
This one should come first of all, I'd say...
Note that it breaks TOD vsyscalls, so you need my patch that removes
support for those for the time being (i.e. until Tony hopefully fixes this
:-). Also, there was a patch implementing read_persistent_clock() and getting
rid of the code setting xtime in time_init(). Attaching them both...
PowerPC_enable_HRT_and_dynticks_support.patch
Again looks like my patch with description/signoff missing for whatever
reason...
PowerPC_no_hz_fix.patch
This has nothing to do with CONFIG_NO_HZ per se -- it fixes the
compilation error introduced by John's patch.
tickless-enable.patch
That one doesn't look quite right...
HTH
Domen
[...]
------------------------------------------------------------------------ This is needed for hrtimer_switch_to_hres() to get called. hrtimer_run_queues() |-tick_check_oneshot_change() | \-timekeeping_is_continuous() | \- flags check \-hrtimer_switch_to_hres()
Signed-off-by: Domen Puncer <redacted>
Index: work-powerpc.git/arch/powerpc/kernel/time.c ===================================================================--- work-powerpc.git.orig/arch/powerpc/kernel/time.c +++ work-powerpc.git/arch/powerpc/kernel/time.c@@ -1039,6 +1039,7 @@ struct clocksource clocksource_timebase .mask = (cycle_t)-1, .mult = 0, .shift = 22, + .flags = CLOCK_SOURCE_VALID_FOR_HRES, };
Hm, has the flag name changed from CLOCK_SOURCE_IS_CONTINOUS? I'm seeign
both there flags, therefore it must be CLOCK_SOURCE_IS_CONTINOUS, not
CLOCK_SOURCE_VALID_FOR_HRES.
WBR, Sergei
PS: All attached patches are against 2.6.21-rt2 -- fitting them into the
current (or whatever) version of the kernel is left as an excercise to the
readers. ;-)
From: Michael Neuling <hidden>
Date: 2007-07-12 15:49:43
Okay. What I didn't want to do is spend a day sifting some other development tree picking out what I think might be possibly sort of the right patches for it. I'd get it wrong because having not worked on it, I don't know what I am even looking for. And I don't want to run -rt or wireless-dev for the benefit of a single feature. What I am after is something like Ingo Molnar throws out.. single patches done the old way, not git trees. It's so much easier to handle and integrate for example into a Gentoo ebuild or to make a tarball of accumulated patches from a certain release kernel.
I'm sooo with ya. I like my patches alphabetised, but no one ever does it for me. :-) Mikey
From: Sergei Shtylyov <hidden>
Date: 2007-07-12 16:30:01
Hello. Matt Sealey wrote:
And I don't want to run -rt or wireless-dev for the benefit of a single
BTW, the latest -rt has has been also released in the broken out form (at
last!) which has "PPC gtod and highres support" section in its series file.
feature. What I am after is something like Ingo Molnar throws out..
One 1.5 Megabyte patch?! Bleh... thanks goodness he (or Thomas) has
finally changed his mind about this. :-)
single patches done the old way, not git trees. It's so much easier to handle and integrate for example into a Gentoo ebuild or to make a tarball of accumulated patches from a certain release kernel.
This also can become a nightmare if you intend to pick up some later fixes
only.
WBR, Sergei
From: Sergei Shtylyov <hidden>
Date: 2007-07-12 16:39:58
Sergei Shtylyov wrote:
Hello. Domen Puncer wrote:quoted
quoted
Does anyone have the definitive patchset to enable the tickless hz, some kind of hrtimer and the other related improvements in the PowerPC tree?quoted
I use attached patches for tickless. Order in which they're applied:
quoted
PowerPC_GENERIC_CLOCKEVENTS.patch
Argh! Finally had forgotten to attach a fixlet for this one, somewaht
adjusting the code for classic PPC decrementer.
[...]
WBR, Sergei
PS: All attached patches are against 2.6.21-rt2 -- fitting them into the current (or whatever) version of the kernel is left as an excercise to the readers. ;-)
This one is for 2.6.21-rt2 as well.
From: Matt Sealey <hidden>
Date: 2007-07-12 20:03:59
Michael Neuling wrote:
quoted
Okay. What I didn't want to do is spend a day sifting some other development tree picking out what I think might be possibly sort of the right patches for it. I'd get it wrong because having not worked on it, I don't know what I am even looking for. And I don't want to run -rt or wireless-dev for the benefit of a single feature. What I am after is something like Ingo Molnar throws out.. single patches done the old way, not git trees. It's so much easier to handle and integrate for example into a Gentoo ebuild or to make a tarball of accumulated patches from a certain release kernel.I'm sooo with ya. I like my patches alphabetised, but no one ever does it for me.
Well my only requirement is numbering them so they patch in order; there are some cute little requirements on that, but I'd rather patch the bare minimum and bring in as few quirks and new features than just grab an entire -rt tree with what amounts to 60 or 70 individual patches and start renumbering them. We already have some ~20 for Efika support on top of 2.6.22 including minor bugfixes and stuff, and the Gentoo genpatches stuff. I really want to get a good start on CFS, hrtimers, dynticks and so on though and see if we can push it to users and get out some decent testing and bug reports. I think it will help everyone if it is not just a feature which hits mainline after 6 months through supposed maturity (when a lack of bug reports may well also be down to lack of interest). I think the Efika as a low-power and fairly average performance board, would benefit (and does benefit!) from features like dynticks, 5200B has a bunch of hrtimers, SLUB gave me some insane speed improvement exactly as the best benchmarks predicted (also got the same under VMware on my x86 laptop, never going back to SLAB now!). The more processor time we can eke out, and the less unecessary work the processor does on housekeeping, the better the board will run for users. Everyone wins :) -- Matt Sealey [off-list ref] Genesi, Manager, Developer Relations
From: Matt Sealey <hidden>
Date: 2007-07-12 20:07:39
Sergei Shtylyov wrote:
Hello. Matt Sealey wrote:quoted
And I don't want to run -rt or wireless-dev for the benefit of a singleBTW, the latest -rt has has been also released in the broken out form (at last!) which has "PPC gtod and highres support" section in its series file.
Hm okay.
quoted
feature. What I am after is something like Ingo Molnar throws out..One 1.5 Megabyte patch?! Bleh... thanks goodness he (or Thomas) has finally changed his mind about this. :-)
Good point, but at least it was nice and self-contained and not mindlessly interdependant on other minor fixes. I think if you are going to patch in a feature that feature should be a feature. Not 8 bugfixes and 8 seperate minifeatures which cooperate to bring in a whole, especialy as a lot of them are so interdependant that they would not have any effect or maybe even break things on their own :)
quoted
single patches done the old way, not git trees. It's so much easier to handle and integrate for example into a Gentoo ebuild or to make a tarball of accumulated patches from a certain release kernel.This also can become a nightmare if you intend to pick up some later fixes only.
Indeed, but you trade off one for the other in everything :) -- Matt Sealey [off-list ref] Genesi, Manager, Developer Relations
From: Geert Uytterhoeven <hidden>
Date: 2007-07-12 20:12:20
On Thu, 12 Jul 2007, Matt Sealey wrote:
Michael Neuling wrote:quoted
quoted
And I don't want to run -rt or wireless-dev for the benefit of a single feature. What I am after is something like Ingo Molnar throws out.. single patches done the old way, not git trees. It's so much easier to handle and integrate for example into a Gentoo ebuild or to make a tarball of accumulated patches from a certain release kernel.I'm sooo with ya. I like my patches alphabetised, but no one ever does it for me.Well my only requirement is numbering them so they patch in order; there are some cute little requirements on that, but I'd rather patch the bare minimum and bring in as few quirks and new features than just grab an entire -rt tree with what amounts to 60 or 70 individual patches and start renumbering them.
That's why quilt uses a series file, so the patch names don't have to be ordered. With kind regards, Geert Uytterhoeven Software Architect Sony Network and Software Technology Center Europe The Corporate Village · Da Vincilaan 7-D1 · B-1935 Zaventem · Belgium Phone: +32 (0)2 700 8453 Fax: +32 (0)2 700 8622 E-mail: Geert.Uytterhoeven@sonycom.com Internet: http://www.sony-europe.com/ Sony Network and Software Technology Center Europe A division of Sony Service Centre (Europe) N.V. Registered office: Technologielaan 7 · B-1840 Londerzeel · Belgium VAT BE 0413.825.160 · RPR Brussels Fortis Bank Zaventem · Swift GEBABEBB08A · IBAN BE39001382358619
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: 2007-07-13 08:34:47
On Thu, 2007-07-12 at 21:04 +0100, Matt Sealey wrote:
We already have some ~20 for Efika support on top of 2.6.22 including minor bugfixes and stuff, and the Gentoo genpatches stuff. I really want to get a good start on CFS, hrtimers, dynticks and so on though and see if we can push it to users and get out some decent testing and bug reports. I think it will help everyone if it is not just a feature which hits mainline after 6 months through supposed maturity (when a lack of bug reports may well also be down to lack of interest).
Why haven't you submited those patches ? The merge window for 2.6.23 is open _now_ Ben
From: Domen Puncer <hidden>
Date: 2007-07-13 08:49:39
On 12/07/07 18:11 +0400, Sergei Shtylyov wrote:
Hello. Domen Puncer wrote:quoted
quoted
Does anyone have the definitive patchset to enable the tickless hz, some kind of hrtimer and the other related improvements in the PowerPC tree?quoted
I use attached patches for tickless. Order in which they're applied:quoted
PowerPC_GENERIC_CLOCKEVENTS.patchThat's my patch which used to have both description and signoff that I'm not seeing in the attached version...
Err, yes, sorry, I don't remember anymore where I picked them, but I'm pretty sure I didn't go delete description and signoff by hand.
quoted
PowerPC_GENERIC_TIME.linux-2.6.18-rc6_timeofday-arch-ppc_C6.patchThis one should come first of all, I'd say... Note that it breaks TOD vsyscalls, so you need my patch that removes support for those for the time being (i.e. until Tony hopefully fixes this :-). Also, there was a patch implementing read_persistent_clock() and getting rid of the code setting xtime in time_init(). Attaching them both...quoted
PowerPC_enable_HRT_and_dynticks_support.patchAgain looks like my patch with description/signoff missing for whatever reason...quoted
PowerPC_no_hz_fix.patchThis has nothing to do with CONFIG_NO_HZ per se -- it fixes the compilation error introduced by John's patch.quoted
tickless-enable.patchThat one doesn't look quite right...
That's because I made it ;-) It did the trick of enabling tickless though. Domen
From: Domen Puncer <hidden>
Date: 2007-07-13 08:59:16
On 12/07/07 13:07 +0100, Matt Sealey wrote:
Domen, You wouldn't have tried these on the Efika yet, would you?
Not yet, but they worked on a mpc5200b based board (lite5200b). Domen
-- Matt Sealey [off-list ref] Genesi, Manager, Developer Relations Domen Puncer wrote:quoted
On 11/07/07 19:06 +0100, Matt Sealey wrote:quoted
Does anyone have the definitive patchset to enable the tickless hz, some kind of hrtimer and the other related improvements in the PowerPC tree?I use attached patches for tickless. Order in which they're applied: PowerPC_GENERIC_CLOCKEVENTS.patch PowerPC_GENERIC_TIME.linux-2.6.18-rc6_timeofday-arch-ppc_C6.patch PowerPC_enable_HRT_and_dynticks_support.patch PowerPC_no_hz_fix.patch tickless-enable.patch HTH Domen
From: Tony Breeds <hidden>
Date: 2007-07-16 00:45:39
On Thu, Jul 12, 2007 at 01:07:26PM +0100, Matt Sealey wrote: Hi Matt,
What does "isn't quite right yet" mean? Broken, acts funny, or just a messy patch?
If you compile with CONFIG_NO_HZ=y, the kernel is broken. Yours Tony linux.conf.au http://linux.conf.au/ || http://lca2008.linux.org.au/ Jan 28 - Feb 02 2008 The Australian Linux Technical Conference!