[PATCH] Fix drivers/rtc/Kconfig for powerpc

STALE7031d

8 messages, 3 authors, 2007-06-08 · open the first message on its own page

[PATCH] Fix drivers/rtc/Kconfig for powerpc

From: Wade Farnsworth <hidden>
Date: 2007-06-06 16:57:45

The powerpc arch uses CONFIG_PPC instead of CONFIG_POWERPC.  This fixes
drivers/rtc/Kconfig to use the correct config option.

Signed-off-by: Wade Farnsworth <redacted>

---
This is a resubmission of a patch I sent a few weeks ago.  I'm
resubmitting this as I haven't seen any activity regarding this patch
since I submitted it.

 drivers/rtc/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6-powerpc-8641/drivers/rtc/Kconfig
===================================================================
--- linux-2.6-powerpc-8641.orig/drivers/rtc/Kconfig
+++ linux-2.6-powerpc-8641/drivers/rtc/Kconfig
@@ -246,7 +246,7 @@ comment "Platform RTC drivers"
 config RTC_DRV_CMOS
 	tristate "PC-style 'CMOS'"
 	depends on RTC_CLASS && (X86 || ALPHA || ARM26 || ARM \
-		|| M32R || ATARI || POWERPC || MIPS)
+		|| M32R || ATARI || PPC || MIPS)
 	help
 	  Say "yes" here to get direct support for the real time clock
 	  found in every PC or ACPI-based system, and some other boards.

Re: [PATCH] Fix drivers/rtc/Kconfig for powerpc

From: Jon Loeliger <hidden>
Date: 2007-06-06 17:07:36

On Wed, 2007-06-06 at 11:57, Wade Farnsworth wrote:
The powerpc arch uses CONFIG_PPC instead of CONFIG_POWERPC.  This fixes
drivers/rtc/Kconfig to use the correct config option.

Signed-off-by: Wade Farnsworth <redacted>

---
This is a resubmission of a patch I sent a few weeks ago.  I'm
resubmitting this as I haven't seen any activity regarding this patch
since I submitted it.
Did you miss where I ACK'ed it 16-May-2007? :-)


        From: 	Jon Loeliger [off-list ref]
        To: 	Wade Farnsworth [off-list ref]
        Cc: 	linuxppc-dev [off-list ref], rtc-linux@googlegroups.com
        Subject: Re: [PATCH] Fix drivers/rtc/Kconfig for powerpc
        Date: 	Wed, 16 May 2007 11:31:26 -0500	
        
        On Tue, 2007-05-15 at 11:53, Wade Farnsworth wrote:
        > The powerpc arch uses CONFIG_PPC instead of CONFIG_POWERPC.  This makes
        > drivers/rtc/Kconfig to use the correct config option.
        > 
        > Signed-off-by: Wade Farnsworth [off-list ref]
        
        Acked-by: Jon Loeliger [off-list ref]

jdl

Re: [PATCH] Fix drivers/rtc/Kconfig for powerpc

From: Wade Farnsworth <hidden>
Date: 2007-06-06 17:17:22

On Wed, 2007-06-06 at 12:07 -0500, Jon Loeliger wrote:
On Wed, 2007-06-06 at 11:57, Wade Farnsworth wrote:
quoted
The powerpc arch uses CONFIG_PPC instead of CONFIG_POWERPC.  This fixes
drivers/rtc/Kconfig to use the correct config option.

Signed-off-by: Wade Farnsworth <redacted>

---
This is a resubmission of a patch I sent a few weeks ago.  I'm
resubmitting this as I haven't seen any activity regarding this patch
since I submitted it.
Did you miss where I ACK'ed it 16-May-2007? :-)
Ah okay, maybe I don't understand what that means.  When you say
"Acked-by" does that mean you'll push it upstream?

What I meant was I haven't seen anybody pick up this patch yet, and
would like to know it if will be, or if there is something else I need
to do.

--Wade

        From: 	Jon Loeliger [off-list ref]
        To: 	Wade Farnsworth [off-list ref]
        Cc: 	linuxppc-dev [off-list ref], rtc-linux@googlegroups.com
        Subject: Re: [PATCH] Fix drivers/rtc/Kconfig for powerpc
        Date: 	Wed, 16 May 2007 11:31:26 -0500	
        
        On Tue, 2007-05-15 at 11:53, Wade Farnsworth wrote:
        > The powerpc arch uses CONFIG_PPC instead of CONFIG_POWERPC.  This makes
        > drivers/rtc/Kconfig to use the correct config option.
        > 
        > Signed-off-by: Wade Farnsworth [off-list ref]
        
        Acked-by: Jon Loeliger [off-list ref]

jdl

Re: [PATCH] Fix drivers/rtc/Kconfig for powerpc

From: Jon Loeliger <hidden>
Date: 2007-06-07 16:08:42

On Wed, 2007-06-06 at 12:17, Wade Farnsworth wrote:
quoted
Did you miss where I ACK'ed it 16-May-2007? :-)
Ah okay, maybe I don't understand what that means.  When you say
"Acked-by" does that mean you'll push it upstream?
I meant that I picked the patch up, applied it to my tree,
tested it, and verified that _I_ thought it was good.
It received my Vote of Confidence, for whatever that is worth.
What I meant was I haven't seen anybody pick up this patch yet, and
would like to know it if will be, or if there is something else I need
to do.
Right.  This patch is in "generic" PowerPC related code,
and not in my area to "push upstream".  I would expect, say,
Paul to pick it up directly.  Perhaps Kumar would pick it up
and stage it for Paul.  Perhaps akpm would pick it up. :-)
--Wade
HTH,
jdl

Re: [PATCH] Fix drivers/rtc/Kconfig for powerpc

From: Wade Farnsworth <hidden>
Date: 2007-06-07 16:33:01

On Thu, 2007-06-07 at 11:08 -0500, Jon Loeliger wrote:
On Wed, 2007-06-06 at 12:17, Wade Farnsworth wrote:
quoted
quoted
Did you miss where I ACK'ed it 16-May-2007? :-)
Ah okay, maybe I don't understand what that means.  When you say
"Acked-by" does that mean you'll push it upstream?
I meant that I picked the patch up, applied it to my tree,
tested it, and verified that _I_ thought it was good.
It received my Vote of Confidence, for whatever that is worth.
Ok.  Thanks for acking it by the way.
quoted
What I meant was I haven't seen anybody pick up this patch yet, and
would like to know it if will be, or if there is something else I need
to do.
Right.  This patch is in "generic" PowerPC related code,
and not in my area to "push upstream".  I would expect, say,
Paul to pick it up directly.  Perhaps Kumar would pick it up
and stage it for Paul.  Perhaps akpm would pick it up. :-)
But since this is in drivers/rtc/Kconfig, wouldn't the maintainer of
that subsystem be expected to pick this up?

Thanks for the clarifications.

--Wade

Re: [PATCH] Fix drivers/rtc/Kconfig for powerpc

From: Jon Loeliger <hidden>
Date: 2007-06-07 16:37:58

On Thu, 2007-06-07 at 11:33, Wade Farnsworth wrote:
But since this is in drivers/rtc/Kconfig, wouldn't the maintainer of
that subsystem be expected to pick this up?
Oh, sure.  In which case he/she may be waiting on
someone over in PowerPC land to ACK it first. :-)
Dunno.

jdl

Re: [PATCH] Fix drivers/rtc/Kconfig for powerpc

From: David Gibson <hidden>
Date: 2007-06-07 23:34:31

On Thu, Jun 07, 2007 at 11:37:46AM -0500, Jon Loeliger wrote:
On Thu, 2007-06-07 at 11:33, Wade Farnsworth wrote:
quoted
But since this is in drivers/rtc/Kconfig, wouldn't the maintainer of
that subsystem be expected to pick this up?
Oh, sure.  In which case he/she may be waiting on
someone over in PowerPC land to ACK it first. :-)
Dunno.
Sure.  This patch is so simple though, I think it could go straight to
Andrew Morton.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

RE: [PATCH] Fix drivers/rtc/Kconfig for powerpc

From: Loeliger Jon-LOELIGER <hidden>
Date: 2007-06-08 14:14:12

=20
Sure.  This patch is so simple though, I think it could go straight to
Andrew Morton.

That was one of my suggestions! :-)

jdl
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help