[PATCH] powerpc: Fix powerpc vmlinux.lds.S

STALE7026d

3 messages, 3 authors, 2007-05-22 · open the first message on its own page

[PATCH] powerpc: Fix powerpc vmlinux.lds.S

From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: 2007-05-22 04:33:10

Sam's recent changes broke things for us, some stuff sneaked in before
the entry point. In fact, we don't need that *(.text.*) thing anymore
and it incorrectly matched .text.init.refok, thus putting it
before .text. .. ouch !

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
---

Index: linux-work/arch/powerpc/kernel/vmlinux.lds.S
===================================================================
--- linux-work.orig/arch/powerpc/kernel/vmlinux.lds.S	2007-05-22 14:16:39.000000000 +1000
+++ linux-work/arch/powerpc/kernel/vmlinux.lds.S	2007-05-22 14:19:00.000000000 +1000
@@ -34,7 +34,6 @@ SECTIONS
 	/* Text and gots */
 	.text : {
 		_text = .;
-		*(.text.*)
 		TEXT_TEXT
 		SCHED_TEXT
 		LOCK_TEXT

Re: [PATCH] powerpc: Fix powerpc vmlinux.lds.S

From: Will Schmidt <hidden>
Date: 2007-05-22 15:02:43

On Tue, 2007-22-05 at 14:33 +1000, Benjamin Herrenschmidt wrote:
Sam's recent changes broke things for us, some stuff sneaked in before
the entry point. In fact, we don't need that *(.text.*) thing anymore
and it incorrectly matched .text.init.refok, thus putting it
before .text. .. ouch !
..  Which manifests itself on some systems as a hang after 
"returning from prom_init".  

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Applying this makes my systems happy again... :-)

Acked-by:  Will Schmidt <redacted>

quoted hunk
---

Index: linux-work/arch/powerpc/kernel/vmlinux.lds.S
===================================================================
--- linux-work.orig/arch/powerpc/kernel/vmlinux.lds.S	2007-05-22 14:16:39.000000000 +1000
+++ linux-work/arch/powerpc/kernel/vmlinux.lds.S	2007-05-22 14:19:00.000000000 +1000
@@ -34,7 +34,6 @@ SECTIONS
 	/* Text and gots */
 	.text : {
 		_text = .;
-		*(.text.*)
 		TEXT_TEXT
 		SCHED_TEXT
 		LOCK_TEXT


_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH] powerpc: Fix powerpc vmlinux.lds.S

From: Kim Phillips <hidden>
Date: 2007-05-22 20:24:41

On Tue, 22 May 2007 10:01:44 -0500
Will Schmidt [off-list ref] wrote:
On Tue, 2007-22-05 at 14:33 +1000, Benjamin Herrenschmidt wrote:
quoted
Sam's recent changes broke things for us, some stuff sneaked in before
the entry point. In fact, we don't need that *(.text.*) thing anymore
and it incorrectly matched .text.init.refok, thus putting it
before .text. .. ouch !
..  Which manifests itself on some systems as a hang after 
"returning from prom_init".  

quoted
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Applying this makes my systems happy again... :-)
same here.
Acked-by:  Will Schmidt <redacted>
Acked-by:  Kim Phillips <redacted>

Kim
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help