DORMANTno replies

[PATCH] don't link timer.o for powerpc systems using generic rtc

From: Guennadi Liakhovetski <hidden>
Date: 2007-05-17 08:56:29
Subsystem: linux for powerpc (32-bit and 64-bit), the rest · Maintainers: Madhavan Srinivasan, Linus Torvalds

With both generic rtc and powerpc timer suspend / resume code now in the 
(powerpc.git) tree, powerpc platforms using the generic timer and enabling 
power management will have timer.o linked in the kernel, which they don't 
need. Moreover, it will likely WARN_ON(!ppc_md.get_rtc_time), save 
zero-time and return no error on suspend...

As a possible solution we can choose not to build timer.o when RTC_CLASS 
is enabled. However, I can imagine systems with 2 rtc's, one served by the 
ppc-rtc, another one generic built as a module, in which case using the 
ppc-rtc for suspend / resume will be impossible. Not to say, that such a 
configuration would be ugly...

Signed-off-by: G. Liakhovetski <redacted>
diff --git a/arch/powerpc/sysdev/Makefile b/arch/powerpc/sysdev/Makefile
index c3ce0bd..31da3b3 100644
--- a/arch/powerpc/sysdev/Makefile
+++ b/arch/powerpc/sysdev/Makefile
@@ -20,7 +20,9 @@ mv64x60-$(CONFIG_PCI)		+= mv64x60_pci.o
 obj-$(CONFIG_MV64X60)		+= $(mv64x60-y) mv64x60_pic.o mv64x60_dev.o
 
 # contains only the suspend handler for time
+ifeq ($(CONFIG_RTC_CLASS),)
 obj-$(CONFIG_PM)		+= timer.o
+endif
 
 ifeq ($(CONFIG_PPC_MERGE),y)
 obj-$(CONFIG_PPC_I8259)		+= i8259.o
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help