[PATCH 1/4] celleb: fix supporting for multiple pci domains

STALE7065d

3 messages, 2 authors, 2007-05-10 · open the first message on its own page

[PATCH 1/4] celleb: fix supporting for multiple pci domains

From: Ishizaki Kou <hidden>
Date: 2007-05-09 07:34:29

Celleb has multiple PCI host bridges (phbs). Previous boot logic gives
non-overlapped bus IDs between PCI host bridges so you can identify
PHB by bus ID. But newer boot logic gives same bus ID between PHBs (it
gives bus ID 0 as root bus.) So we have to set 'phb->buid' as
non-zero.

Signed-off-by: Kou Ishizaki <redacted>
---

Index: linux-powerpc-git/arch/powerpc/platforms/celleb/pci.c
diff -u linux-powerpc-git/arch/powerpc/platforms/celleb/pci.c:1.1.1.3 linux-powerpc-git/arch/powerpc/platforms/celleb/pci.c:1.25.2.2
--- linux-powerpc-git/arch/powerpc/platforms/celleb/pci.c:1.1.1.3	Wed Apr 18 13:53:48 2007
+++ linux-powerpc-git/arch/powerpc/platforms/celleb/pci.c	Tue May  8 14:20:03 2007
@@ -457,6 +457,7 @@
 
 	pr_debug("PCI: celleb_setup_phb() %s\n", name);
 	phb_set_bus_ranges(dev, phb);
+	phb->buid = 1;
 
 	if (strcmp(name, "epci") == 0) {
 		phb->ops = &celleb_epci_ops;

Re: [PATCH 1/4] celleb: fix supporting for multiple pci domains

From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: 2007-05-09 07:50:08

On Wed, 2007-05-09 at 16:34 +0900, Ishizaki Kou wrote:
Celleb has multiple PCI host bridges (phbs). Previous boot logic gives
non-overlapped bus IDs between PCI host bridges so you can identify
PHB by bus ID. But newer boot logic gives same bus ID between PHBs (it
gives bus ID 0 as root bus.) So we have to set 'phb->buid' as
non-zero.
Shouldn't you obtain it from the device-tree ?

Ben.

Re: [PATCH 1/4] celleb: fix supporting for multiple pci domains

From: Ishizaki Kou <hidden>
Date: 2007-05-10 07:14:27

Ben-san,
quoted
Celleb has multiple PCI host bridges (phbs). Previous boot logic
gives
quoted
non-overlapped bus IDs between PCI host bridges so you can identify
PHB by bus ID. But newer boot logic gives same bus ID between PHBs
(it
quoted
gives bus ID 0 as root bus.) So we have to set 'phb->buid' as
non-zero.
Shouldn't you obtain it from the device-tree ?
With 'Celleb', we don't have 'buid' in the device-tree, because neither
hypervisor calls nor RTAS subsystem uses 'buid.' So we didn't choose
to obtain 'buid' from the device-tree.

Best regards,
Kou Ishizaki
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help