[PATCH] BLK_DEV_IDE_CELLEB dependency fix

STALE7084d

3 messages, 3 authors, 2007-03-15 · open the first message on its own page

[PATCH] BLK_DEV_IDE_CELLEB dependency fix

From: Akira Iguchi <hidden>
Date: 2007-03-15 06:28:32

It's bool and it depends on BLK_DEV_IDE
 => should depend on BLK_DEV_IDE=y

And move it to "if BLK_DEV_IDEDMA_PCI" block because it depends on 
BLK_DEV_IDEDMA_PCI.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Kou Ishizaki <redacted>
Signed-off-by: Akira Iguchi <redacted>
---

diff -Nrpu -X linux-2.6.21-rc3/Documentation/dontdiff linux-2.6.21-rc3/drivers/ide/Kconfig linux-2.6.21-rc3.mod/drivers/ide/Kconfig
--- linux-2.6.21-rc3/drivers/ide/Kconfig	2007-03-07 13:41:20.000000000 +0900
+++ linux-2.6.21-rc3.mod/drivers/ide/Kconfig	2007-03-15 23:49:33.000000000 +0900
@@ -769,6 +769,14 @@ config BLK_DEV_TC86C001
 	help
 	This driver adds support for Toshiba TC86C001 GOKU-S chip.
 
+config BLK_DEV_IDE_CELLEB
+	bool "Toshiba's Cell Reference Set IDE support"
+	depends on PPC_CELLEB && BLK_DEV_IDE=y
+	help
+	  This driver provides support for the built-in IDE controller on
+	  Toshiba Cell Reference Board.
+	  If unsure, say Y.
+
 endif
 
 config BLK_DEV_IDE_PMAC
@@ -800,14 +808,6 @@ config BLK_DEV_IDEDMA_PMAC
 	  to transfer data to and from memory.  Saying Y is safe and improves
 	  performance.
 
-config BLK_DEV_IDE_CELLEB
-	bool "Toshiba's Cell Reference Set IDE support"
-	depends on PPC_CELLEB
-	help
-	  This driver provides support for the built-in IDE controller on
-	  Toshiba Cell Reference Board.
-	  If unsure, say Y.
-
 config BLK_DEV_IDE_SWARM
 	tristate "IDE for Sibyte evaluation boards"
 	depends on SIBYTE_SB1xxx_SOC

Re: [PATCH] BLK_DEV_IDE_CELLEB dependency fix

From: Sergei Shtylyov <hidden>
Date: 2007-03-15 14:30:56

Hello.

Akira Iguchi wrote:
It's bool and it depends on BLK_DEV_IDE
 => should depend on BLK_DEV_IDE=y
    Hm, why I'm seeing module_init() in the driver? :-)
And move it to "if BLK_DEV_IDEDMA_PCI" block because it depends on 
BLK_DEV_IDEDMA_PCI.
    IMHO, that driver shouldn't be in drivers/ide/ppc/ then...  Why it got 
there (the same question about PowerMac driver)?
quoted hunk
diff -Nrpu -X linux-2.6.21-rc3/Documentation/dontdiff linux-2.6.21-rc3/drivers/ide/Kconfig linux-2.6.21-rc3.mod/drivers/ide/Kconfig
--- linux-2.6.21-rc3/drivers/ide/Kconfig	2007-03-07 13:41:20.000000000 +0900
+++ linux-2.6.21-rc3.mod/drivers/ide/Kconfig	2007-03-15 23:49:33.000000000 +0900
@@ -769,6 +769,14 @@ config BLK_DEV_TC86C001
 	help
 	This driver adds support for Toshiba TC86C001 GOKU-S chip.
 
+config BLK_DEV_IDE_CELLEB
+	bool "Toshiba's Cell Reference Set IDE support"
+	depends on PPC_CELLEB && BLK_DEV_IDE=y
+	help
+	  This driver provides support for the built-in IDE controller on
+	  Toshiba Cell Reference Board.
+	  If unsure, say Y.
+
 endif
 
 config BLK_DEV_IDE_PMAC
@@ -800,14 +808,6 @@ config BLK_DEV_IDEDMA_PMAC
 	  to transfer data to and from memory.  Saying Y is safe and improves
 	  performance.
 
-config BLK_DEV_IDE_CELLEB
-	bool "Toshiba's Cell Reference Set IDE support"
-	depends on PPC_CELLEB
-	help
-	  This driver provides support for the built-in IDE controller on
-	  Toshiba Cell Reference Board.
-	  If unsure, say Y.
-
 config BLK_DEV_IDE_SWARM
 	tristate "IDE for Sibyte evaluation boards"
 	depends on SIBYTE_SB1xxx_SOC
MBR, Sergei

Re: [PATCH] BLK_DEV_IDE_CELLEB dependency fix

From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: 2007-03-15 17:33:20

On Thu, 2007-03-15 at 17:30 +0300, Sergei Shtylyov wrote:
Hello.

Akira Iguchi wrote:
quoted
It's bool and it depends on BLK_DEV_IDE
 => should depend on BLK_DEV_IDE=y
    Hm, why I'm seeing module_init() in the driver? :-)
quoted
And move it to "if BLK_DEV_IDEDMA_PCI" block because it depends on 
BLK_DEV_IDEDMA_PCI.
    IMHO, that driver shouldn't be in drivers/ide/ppc/ then...  Why it got 
there (the same question about PowerMac driver)?
Not sure... some reorg changes ide-pmac.c into ppc/pmac.c or such, I
don't remember who did it tho.

Ben.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help