Please pull from 'for_linus' branch

Subsystems: linux for powerpc (32-bit and 64-bit), the rest

2 messages, 2 authors, 2007-03-29 · open the first message on its own page

Please pull from 'for_linus' branch

From: Kumar Gala <hidden>
Date: 2007-03-29 19:46:56

Linus,

Please pull from 'for_linus' branch of
master.kernel.org/pub/scm/linux/kernel/git/galak/powerpc.git

These are a few fixes for 2.6.21 related to the quicc engine support.

to receive the following updates:

 arch/powerpc/sysdev/qe_lib/qe.c |    6 +++---
 include/asm-powerpc/immap_qe.h  |    3 ++-
 2 files changed, 5 insertions(+), 4 deletions(-)

Chuck Meade (1):
      [POWERPC] qe: Fix QUICC Engine SDMA setup errors

Timur Tabi (1):
      [POWERPC] qe: ucc_slow.guemr is in the wrong place
diff --git a/arch/powerpc/sysdev/qe_lib/qe.c b/arch/powerpc/sysdev/qe_lib/qe.c
index e3d71e0..43f6cc9 100644
--- a/arch/powerpc/sysdev/qe_lib/qe.c
+++ b/arch/powerpc/sysdev/qe_lib/qe.c
@@ -251,13 +251,13 @@ static int qe_sdma_init(void)

 	/* allocate 2 internal temporary buffers (512 bytes size each) for
 	 * the SDMA */
-	sdma_buf_offset = qe_muram_alloc(512 * 2, 64);
+ 	sdma_buf_offset = qe_muram_alloc(512 * 2, 4096);
 	if (IS_MURAM_ERR(sdma_buf_offset))
 		return -ENOMEM;

 	out_be32(&sdma->sdebcr, sdma_buf_offset & QE_SDEBCR_BA_MASK);
-	out_be32(&sdma->sdmr, (QE_SDMR_GLB_1_MSK | (0x1 >>
-					QE_SDMR_CEN_SHIFT)));
+ 	out_be32(&sdma->sdmr, (QE_SDMR_GLB_1_MSK |
+ 					(0x1 << QE_SDMR_CEN_SHIFT)));

 	return 0;
 }
diff --git a/include/asm-powerpc/immap_qe.h b/include/asm-powerpc/immap_qe.h
index 9fdd049..1020b7f 100644
--- a/include/asm-powerpc/immap_qe.h
+++ b/include/asm-powerpc/immap_qe.h
@@ -258,8 +258,9 @@ struct ucc_slow {
 	u8	uccs;		/* UCCx status register */
 	u8	res3[0x24];
 	__be16	utpt;
+	u8	res4[0x52];
 	u8	guemr;		/* UCC general extended mode register */
-	u8	res4[0x200 - 0x091];
+	u8	res5[0x200 - 0x091];
 } __attribute__ ((packed));

 /* QE UCC Fast */

Re: Please pull from 'for_linus' branch

From: Linus Torvalds <torvalds@linux-foundation.org>
Date: 2007-03-29 20:15:24


On Thu, 29 Mar 2007, Kumar Gala wrote:
Please pull from 'for_linus' branch of
master.kernel.org/pub/scm/linux/kernel/git/galak/powerpc.git
Please don't do this to me.

 - give a valid URL! 

   You could have either added a "ssh://" to before that string, or used a 
   colon between the hostname and the path, but the URL you quoted is 
   broken.

 - put the branch-name after the URL on the same line, so that I can 
   cut-and-paste them together rather than separately (and so that I don't 
   miss the fact that it wasn't the default branch)

IOW, it should have said

  Please pull from the 'for_linus' branch at

	master.kernel.org:/pub/scm/linux/kernel/git/galak/powerpc.git for_linus

or something similar.

Thanks from your anal and grumpy kernel maintainer,

		Linus
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help