[PATCH] Added QE to the list of default scanned OF devices

Subsystems: linux for powerpc (32-bit and 64-bit), the rest

STALE7149d

6 messages, 3 authors, 2007-02-09 · open the first message on its own page

[PATCH] Added QE to the list of default scanned OF devices

From: Andy Fleming <hidden>
Date: 2007-02-08 16:57:06

Signed-off-by: Andrew Fleming <redacted>
---
 arch/powerpc/kernel/of_platform.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/powerpc/kernel/of_platform.c b/arch/powerpc/kernel/of_platform.c
index b734517..43c5a00 100644
--- a/arch/powerpc/kernel/of_platform.c
+++ b/arch/powerpc/kernel/of_platform.c
@@ -51,6 +51,7 @@ static struct of_device_id of_default_bu
 	{ .type = "plb4", },
 	{ .type = "opb", },
 	{ .type = "ebc", },
+	{ .type = "qe", },
 	{},
 };
 
-- 
1.4.4

Re: [PATCH] Added QE to the list of default scanned OF devices

From: Kumar Gala <hidden>
Date: 2007-02-08 17:14:27

On Thu, 8 Feb 2007, Andy Fleming wrote:
Signed-off-by: Andrew Fleming <redacted>
---
arch/powerpc/kernel/of_platform.c |    1 +
1 files changed, 1 insertions(+), 0 deletions(-)
applied.

- k

Re: [PATCH] Added QE to the list of default scanned OF devices

From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: 2007-02-08 22:28:00

On Thu, 2007-02-08 at 10:56 -0600, Andy Fleming wrote:
Signed-off-by: Andrew Fleming <redacted>
---
 arch/powerpc/kernel/of_platform.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
As I said several times on irc, I dislike the "default list" and I'm
tempted to remove it. I'd much prefer if your platform passed in the
list of what it wants exposed.

Ben.
quoted hunk
diff --git a/arch/powerpc/kernel/of_platform.c b/arch/powerpc/kernel/of_platform.c
index b734517..43c5a00 100644
--- a/arch/powerpc/kernel/of_platform.c
+++ b/arch/powerpc/kernel/of_platform.c
@@ -51,6 +51,7 @@ static struct of_device_id of_default_bu
 	{ .type = "plb4", },
 	{ .type = "opb", },
 	{ .type = "ebc", },
+	{ .type = "qe", },
 	{},
 };
 

Re: [PATCH] Added QE to the list of default scanned OF devices

From: Kumar Gala <hidden>
Date: 2007-02-08 22:57:50

On Feb 8, 2007, at 4:27 PM, Benjamin Herrenschmidt wrote:
On Thu, 2007-02-08 at 10:56 -0600, Andy Fleming wrote:
quoted
Signed-off-by: Andrew Fleming <redacted>
---
 arch/powerpc/kernel/of_platform.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
As I said several times on irc, I dislike the "default list" and I'm
tempted to remove it. I'd much prefer if your platform passed in the
list of what it wants exposed.
How about we add 'qe' for now and look at removing the list going  
forward.

- k
quoted
diff --git a/arch/powerpc/kernel/of_platform.c b/arch/powerpc/ 
kernel/of_platform.c
index b734517..43c5a00 100644
--- a/arch/powerpc/kernel/of_platform.c
+++ b/arch/powerpc/kernel/of_platform.c
@@ -51,6 +51,7 @@ static struct of_device_id of_default_bu
 	{ .type = "plb4", },
 	{ .type = "opb", },
 	{ .type = "ebc", },
+	{ .type = "qe", },
 	{},
 };

Re: [PATCH] Added QE to the list of default scanned OF devices

From: Kumar Gala <hidden>
Date: 2007-02-08 23:26:09

On Feb 8, 2007, at 4:56 PM, Kumar Gala wrote:
On Feb 8, 2007, at 4:27 PM, Benjamin Herrenschmidt wrote:
quoted
On Thu, 2007-02-08 at 10:56 -0600, Andy Fleming wrote:
quoted
Signed-off-by: Andrew Fleming <redacted>
---
 arch/powerpc/kernel/of_platform.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
As I said several times on irc, I dislike the "default list" and I'm
tempted to remove it. I'd much prefer if your platform passed in the
list of what it wants exposed.
How about we add 'qe' for now and look at removing the list going
forward.
Actually, nevermind.  I've dropped the patch and will make the guys  
do what you are suggesting.  Can you look at the other users (cell,  
pmac?) and change them so we can remove the "default list"

- k

Re: [PATCH] Added QE to the list of default scanned OF devices

From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: 2007-02-09 01:00:13

On Thu, 2007-02-08 at 17:25 -0600, Kumar Gala wrote:
On Feb 8, 2007, at 4:56 PM, Kumar Gala wrote:
quoted
On Feb 8, 2007, at 4:27 PM, Benjamin Herrenschmidt wrote:
quoted
On Thu, 2007-02-08 at 10:56 -0600, Andy Fleming wrote:
quoted
Signed-off-by: Andrew Fleming <redacted>
---
 arch/powerpc/kernel/of_platform.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
As I said several times on irc, I dislike the "default list" and I'm
tempted to remove it. I'd much prefer if your platform passed in the
list of what it wants exposed.
How about we add 'qe' for now and look at removing the list going
forward.
Actually, nevermind.  I've dropped the patch and will make the guys  
do what you are suggesting.  Can you look at the other users (cell,  
pmac?) and change them so we can remove the "default list"
Only Cell is using that afaik. I'll do a patch asap.

Ben.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help