Re: [Cbe-oss-dev] [RFC, PATCH 1/4] Add support to OProfile for profiling Cell BE SPUs -- update
From: Christoph Hellwig <hch@lst.de>
Date: 2007-01-31 08:48:40
Also in:
lkml
From: Christoph Hellwig <hch@lst.de>
Date: 2007-01-31 08:48:40
Also in:
lkml
On Wed, Jan 31, 2007 at 09:57:26AM +1100, Benjamin Herrenschmidt wrote:
On Tue, 2007-01-30 at 14:49 -0800, Carl Love wrote:quoted
Christoph: In our earlier work on the PPU profiling patch, Benjamin Herrenschmidt said that we should remove macros that are only used once and just put the actual code in. That is why the macros were removed.Heh... there is a balance to be found... In some cases, inline functions might be better too.
Well, unless there's a very good reasons against it (token pasting, header pollution) inlines are always preferable over macros, but I didn't want to bring that issue up aswell..