# \[PATCH 20/59\] sysctl: cdrom Don't set de-\>owner - From: Eric W. Biederman \ - Date: 2007-01-16 16:47:26 - List: linuxppc-dev - Page: https://ratatoskr.run/linuxppc-dev/2007/01/912017 - Thread: https://ratatoskr.run/netdev/2007/01/912004/t.md ```text From: Eric W. Biederman - unquoted There is no need for open files in /proc/sys/XXX to hold a reference count on the module that provides the file to prevent module unload races. While there is code active in the module p->used in the sysctl_table_header is incremented, preventing the sysctl from being unregisted. Once the sysctl is unregistered it cannot be found. Open files are also not a problem as they revalidate the sysctl information and bump p->used before accessing module code. So setting de->owner is unnecessary, makes for a bad example and gets in my way of removing ctl_table->de. Signed-off-by: Eric W. Biederman --- drivers/cdrom/cdrom.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c index f0a6801..14f72c4 100644 --- a/drivers/cdrom/cdrom.c +++ b/drivers/cdrom/cdrom.c @@ -3554,8 +3554,6 @@ static void cdrom_sysctl_register(void) return; cdrom_sysctl_header = register_sysctl_table(cdrom_root_table, 0); - if (cdrom_root_table->ctl_name && cdrom_root_table->child->de) - cdrom_root_table->child->de->owner = THIS_MODULE; /* set the defaults */ cdrom_sysctl_settings.autoclose = autoclose; -- 1.4.4.1.g278f ```