Hello,
Doesn't build on my iMac G3 based garage jukebox ;-)
arch/powerpc/kernel/of_platform.c:479: error: unknown field 'multithread_probe' specified in initializer
arch/powerpc/kernel/of_platform.c:479: warning: initialization makes pointer from integer without a cast
make[1]: *** [arch/powerpc/kernel/of_platform.o] Blad 1
make: *** [arch/powerpc/kernel] Blad 2
I guess someone who knows multithread code should take a look at it.
--
Regards,
Mariusz Kozlowski
From: Tim Schmielau <hidden> Date: 2007-01-05 18:45:27
On Fri, 5 Jan 2007, Mariusz Kozlowski wrote:
Doesn't build on my iMac G3 based garage jukebox ;-)
arch/powerpc/kernel/of_platform.c:479: error: unknown field 'multithread_probe' specified in initializer
arch/powerpc/kernel/of_platform.c:479: warning: initialization makes pointer from integer without a cast
make[1]: *** [arch/powerpc/kernel/of_platform.o] Blad 1
make: *** [arch/powerpc/kernel] Blad 2
Doesn't build on my iMac G3 based garage jukebox ;-)
arch/powerpc/kernel/of_platform.c:479: error: unknown field 'multithread_probe' specified in initializer
arch/powerpc/kernel/of_platform.c:479: warning: initialization makes pointer from integer without a cast
make[1]: *** [arch/powerpc/kernel/of_platform.o] Blad 1
make: *** [arch/powerpc/kernel] Blad 2
Can you please post your .config?
Sure. Please find it attached.
processor : 0
cpu : 740/750
temperature : 28-31 C (uncalibrated)
clock : 400MHz
revision : 2.2 (pvr 0008 0202)
bogomips : 796.67
machine : PowerMac2,1
motherboard : PowerMac2,1 MacRISC2 MacRISC Power Macintosh
detected as : 66 (iMac FireWire)
pmac flags : 00000005
L2 cache : 512K unified
memory : 256MB
pmac-generation : NewWorld
Gnu C 4.1.2
Gnu make 3.81
binutils 2.17
util-linux 2.12r
mount 2.12r
module-init-tools 3.3-pre2
e2fsprogs 1.40-WIP
Linux C Library 2.3.6
Dynamic linker (ldd) 2.3.6
Procps 3.2.7
Net-tools 1.60
Console-tools 0.2.3
Sh-utils 5.97
Modules Loaded ipv6 af_packet tsdev eth1394 tulip crc32 ohci1394 ieee1394 uninorth_agp agpgart dm_snapshot dm_mirror dm_mod snd_powermac snd_pcm_oss snd_pcm snd_page_alloc snd_mixer_oss snd_seq_oss snd_seq_device snd_seq_midi_event snd_seq snd_timer snd soundcore ide_cd cdrom joydev evdev ext3 jbd mbcache usbhid uhci_hcd ohci_hcd usbcore ide_disk unix
--
Regards,
Mariusz Kozlowski
From: Benjamin Herrenschmidt <benh@kernel.crashing.org> Date: 2007-01-05 20:56:01
On Fri, 2007-01-05 at 17:23 +0100, Mariusz Kozlowski wrote:
Hello,
Doesn't build on my iMac G3 based garage jukebox ;-)
arch/powerpc/kernel/of_platform.c:479: error: unknown field 'multithread_probe' specified in initializer
arch/powerpc/kernel/of_platform.c:479: warning: initialization makes pointer from integer without a cast
make[1]: *** [arch/powerpc/kernel/of_platform.o] Blad 1
make: *** [arch/powerpc/kernel] Blad 2
I guess someone who knows multithread code should take a look at it.
Hrm. struct driver -> multithread_probe is gone in -mm ?
Ben.
From: Andrew Morton <hidden> Date: 2007-01-05 21:15:47
On Sat, 06 Jan 2007 07:55:36 +1100
Benjamin Herrenschmidt [off-list ref] wrote:
On Fri, 2007-01-05 at 17:23 +0100, Mariusz Kozlowski wrote:
quoted
Hello,
Doesn't build on my iMac G3 based garage jukebox ;-)
arch/powerpc/kernel/of_platform.c:479: error: unknown field 'multithread_probe' specified in initializer
arch/powerpc/kernel/of_platform.c:479: warning: initialization makes pointer from integer without a cast
make[1]: *** [arch/powerpc/kernel/of_platform.o] Blad 1
make: *** [arch/powerpc/kernel] Blad 2
I guess someone who knows multithread code should take a look at it.
Hrm. struct driver -> multithread_probe is gone in -mm ?
From: Benjamin Herrenschmidt <benh@kernel.crashing.org> Date: 2007-01-05 21:25:19
On Fri, 2007-01-05 at 13:15 -0800, Andrew Morton wrote:
On Sat, 06 Jan 2007 07:55:36 +1100
Benjamin Herrenschmidt [off-list ref] wrote:
quoted
On Fri, 2007-01-05 at 17:23 +0100, Mariusz Kozlowski wrote:
quoted
Hello,
Doesn't build on my iMac G3 based garage jukebox ;-)
arch/powerpc/kernel/of_platform.c:479: error: unknown field 'multithread_probe' specified in initializer
arch/powerpc/kernel/of_platform.c:479: warning: initialization makes pointer from integer without a cast
make[1]: *** [arch/powerpc/kernel/of_platform.o] Blad 1
make: *** [arch/powerpc/kernel] Blad 2
I guess someone who knows multithread code should take a look at it.
Hrm. struct driver -> multithread_probe is gone in -mm ?
Hrm. I disagree with this change. I have a few cases where drivers
actually want to explicitely do that. I suppose they can always fire off
a thread themselves from probe() but I don't see the reason to move it
to the bus type...
Easy enough for the bus type to force it if it wants.
Ben.
Hrm. I disagree with this change. I have a few cases where drivers
actually want to explicitely do that. I suppose they can always fire off
a thread themselves from probe() but I don't see the reason to move it
to the bus type...
The idea behind this is to have a probing thread for each device that
does the actual work (call probe for the matching drivers) so that
multiple devices can be probed in parallel. The decision to do this can
only be made at the bus level.
Previously, the code made it possible to have a probing thread for each
matching driver for the same device in parallel. I didn't see any
benefit in that, but maybe I'm just dense...
--
Cornelia Huck
Linux for zSeries Developer
Tel.: +49-7031-16-4837, Mail: cornelia.huck@de.ibm.com
From: Benjamin Herrenschmidt <benh@kernel.crashing.org> Date: 2007-01-08 21:19:45
The idea behind this is to have a probing thread for each device that
does the actual work (call probe for the matching drivers) so that
multiple devices can be probed in parallel. The decision to do this can
only be made at the bus level.
Previously, the code made it possible to have a probing thread for each
matching driver for the same device in parallel. I didn't see any
benefit in that, but maybe I'm just dense...
Hrm... I see. Well, I was using it from the driver because I have a
driver that needs to wait in it's probe() routing for another driver to
show up for another device (they are linked in some ways, but that is
not expressed via bus bindings).
I suppose I'll just have probe() fire off a kthread instead.
Cheers,
Ben.