[PATCH 2.6.19-rc4 1/3] ehea: Nullpointer dereferencation fix

STALE7285d

2 messages, 2 authors, 2006-11-06 · open the first message on its own page

[PATCH 2.6.19-rc4 1/3] ehea: Nullpointer dereferencation fix

From: Thomas Klein <hidden>
Date: 2006-11-03 16:47:25

Fix: Must check for nullpointer before dereferencing it - not afterwards.

Signed-off-by: Thomas Klein <redacted>
---

diff -Nurp git.netdev-2.6.base/drivers/net/ehea/ehea_qmr.c git.netdev-2.6/drivers/net/ehea/ehea_qmr.c
--- git.netdev-2.6.base/drivers/net/ehea/ehea_qmr.c	2006-11-03 14:19:51.000000000 +0100
+++ git.netdev-2.6/drivers/net/ehea/ehea_qmr.c	2006-11-03 14:27:53.000000000 +0100
@@ -209,11 +209,11 @@ int ehea_destroy_cq(struct ehea_cq *cq)
 {
 	u64 adapter_handle, hret;
 
-	adapter_handle = cq->adapter->handle;
-
 	if (!cq)
 		return 0;
 
+	adapter_handle = cq->adapter->handle;
+
 	/* deregister all previous registered pages */
 	hret = ehea_h_free_resource(adapter_handle, cq->fw_handle);
 	if (hret != H_SUCCESS) {

Re: [PATCH 2.6.19-rc4 1/3] ehea: Nullpointer dereferencation fix

From: Jeff Garzik <hidden>
Date: 2006-11-06 07:55:29

applied 1-3
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help